From: "Andreas Hindborg (Samsung)" <nmi@metaspace.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
gost.dev@samsung.com,
linux-block@vger.kernel.org (open list:BLOCK LAYER),
Hans Holmberg <Hans.Holmberg@wdc.com>,
Matias Bjorling <Matias.Bjorling@wdc.com>,
Andreas Hindborg <a.hindborg@samsung.com>,
Minwoo Im <minwoo.im.dev@gmail.com>, Jens Axboe <axboe@kernel.dk>,
Johannes Thumshirn <jth@kernel.org>,
Aravind Ramesh <Aravind.Ramesh@wdc.com>,
Damien Le Moal <dlemoal@kernel.org>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v10 1/3] ublk: add helper to check if device supports user copy
Date: Thu, 3 Aug 2023 16:06:59 +0200 [thread overview]
Message-ID: <20230803140701.18515-2-nmi@metaspace.dk> (raw)
In-Reply-To: <20230803140701.18515-1-nmi@metaspace.dk>
From: Andreas Hindborg <a.hindborg@samsung.com>
This will be used by ublk zoned storage support.
Signed-off-by: Andreas Hindborg <a.hindborg@samsung.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
---
drivers/block/ublk_drv.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
index 21d2e71c5514..db3523e281a6 100644
--- a/drivers/block/ublk_drv.c
+++ b/drivers/block/ublk_drv.c
@@ -185,6 +185,11 @@ struct ublk_params_header {
__u32 types;
};
+static inline bool ublk_dev_is_user_copy(const struct ublk_device *ub)
+{
+ return ub->dev_info.flags & UBLK_F_USER_COPY;
+}
+
static inline void __ublk_complete_rq(struct request *req);
static void ublk_complete_rq(struct kref *ref);
@@ -2038,7 +2043,7 @@ static int ublk_ctrl_add_dev(struct io_uring_cmd *cmd)
UBLK_F_URING_CMD_COMP_IN_TASK;
/* GET_DATA isn't needed any more with USER_COPY */
- if (ub->dev_info.flags & UBLK_F_USER_COPY)
+ if (ublk_dev_is_user_copy(ub))
ub->dev_info.flags &= ~UBLK_F_NEED_GET_DATA;
/* We are not ready to support zero copy */
--
2.41.0
next prev parent reply other threads:[~2023-08-03 14:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 14:06 [PATCH v10 0/3] ublk: enable zoned storage support Andreas Hindborg (Samsung)
2023-08-03 14:06 ` Andreas Hindborg (Samsung) [this message]
2023-08-03 19:02 ` [PATCH v10 1/3] ublk: add helper to check if device supports user copy Johannes Thumshirn
2023-08-03 14:07 ` [PATCH v10 2/3] ublk: move check for empty address field on command submission Andreas Hindborg (Samsung)
2023-08-04 9:01 ` Ming Lei
2023-08-04 10:08 ` Andreas Hindborg (Samsung)
2023-08-03 14:07 ` [PATCH v10 3/3] ublk: enable zoned storage support Andreas Hindborg (Samsung)
2023-08-03 18:58 ` kernel test robot
2023-08-03 19:07 ` Johannes Thumshirn
2023-08-04 8:59 ` Andreas Hindborg (Samsung)
2023-08-04 10:25 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803140701.18515-2-nmi@metaspace.dk \
--to=nmi@metaspace.dk \
--cc=Aravind.Ramesh@wdc.com \
--cc=Hans.Holmberg@wdc.com \
--cc=Matias.Bjorling@wdc.com \
--cc=a.hindborg@samsung.com \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=gost.dev@samsung.com \
--cc=hch@infradead.org \
--cc=jth@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=minwoo.im.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®