From: Alex Williamson <alex.williamson@redhat.com>
To: bhelgaas@google.com
Cc: Alex Williamson <alex.williamson@redhat.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
eric.auger@redhat.com
Subject: [PATCH v2 0/2] PCI: Protect VPD and PME accesses from power management
Date: Thu, 3 Aug 2023 11:12:31 -0600 [thread overview]
Message-ID: <20230803171233.3810944-1-alex.williamson@redhat.com> (raw)
Since v5.19, vfio-pci makes use of runtime power management on devices.
This has the effect of potentially putting entire sub-hierarchies into
lower power states, which has exposed some gaps in the PCI subsystem
around power management support.
The first issue is that lspci accesses the VPD sysfs interface, which
does not provide the same power management wrappers as general config
space.
The next covers PME, where we attempt to skip devices based on their PCI
power state, but don't protect changes to that state or look at the
overall runtime power management state of the device.
This latter patch addresses the issue noted by Eric in the follow-ups to
v1 linked below.
These patches are logically independent, but only together resolve an
issue on Eric's system where a pair of endpoints bound to vfio-pci and
unused by userspace drivers trigger faults through lspci and PME
polling. Thanks,
Alex
v1: https://lore.kernel.org/all/20230707151044.1311544-1-alex.williamson@redhat.com/
Alex Williamson (2):
PCI/VPD: Add runtime power management to sysfs interface
PCI: Fix runtime PM race with PME polling
drivers/pci/pci.c | 23 ++++++++++++++++-------
drivers/pci/vpd.c | 34 ++++++++++++++++++++++++++++++++--
2 files changed, 48 insertions(+), 9 deletions(-)
--
2.40.1
next reply other threads:[~2023-08-03 17:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 17:12 Alex Williamson [this message]
2023-08-03 17:12 ` [PATCH v2 1/2] PCI/VPD: Add runtime power management to sysfs interface Alex Williamson
2023-08-10 15:59 ` Bjorn Helgaas
2023-08-10 16:26 ` Alex Williamson
2023-08-11 19:25 ` Bjorn Helgaas
2023-08-11 19:56 ` Alex Williamson
2023-08-03 17:12 ` [PATCH v2 2/2] PCI: Fix runtime PM race with PME polling Alex Williamson
2024-01-18 18:50 ` Alex Williamson
2024-01-22 22:17 ` Lukas Wunner
2024-01-22 22:50 ` Alex Williamson
2024-01-23 4:46 ` Alex Williamson
2024-01-23 4:48 ` Sanath S
2024-01-23 10:45 ` Lukas Wunner
2024-01-23 15:55 ` Alex Williamson
2024-01-23 16:12 ` Lukas Wunner
2024-01-23 16:47 ` Alex Williamson
2023-08-10 18:29 ` [PATCH v2 0/2] PCI: Protect VPD and PME accesses from power management Bjorn Helgaas
2023-08-10 18:54 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803171233.3810944-1-alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=eric.auger@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®