From: Christoph Hellwig <hch@infradead.org>
To: axboe@kernel.dk
Cc: lizetao1@huawei.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: [PATCH] romfs: only select BUFFER_HEAD for the block based path
Date: Fri, 4 Aug 2023 12:26:48 +0200 [thread overview]
Message-ID: <20230804102648.78683-1-hch@infradead.org> (raw)
selecting BUFFER_HEAD unconditionally does not work as romfs can also
be built with only the MTD backend and thus without CONFIG_BLOCK.
Fixes: 0f842210d97a ("fs/Kconfig: Fix compile error for romfs")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/romfs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/romfs/Kconfig b/fs/romfs/Kconfig
index 3f6b550eee6192..f24a96a331af1b 100644
--- a/fs/romfs/Kconfig
+++ b/fs/romfs/Kconfig
@@ -2,7 +2,6 @@
config ROMFS_FS
tristate "ROM file system support"
depends on BLOCK || MTD
- select BUFFER_HEAD
help
This is a very small read-only file system mainly intended for
initial ram disks of installation disks, but it could be used for
@@ -58,6 +57,7 @@ endchoice
config ROMFS_ON_BLOCK
bool
default y if ROMFS_BACKED_BY_BLOCK || ROMFS_BACKED_BY_BOTH
+ select BUFFER_HEAD
config ROMFS_ON_MTD
bool
--
2.39.2
next reply other threads:[~2023-08-04 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 10:26 Christoph Hellwig [this message]
2023-08-04 10:38 ` Christoph Hellwig
2023-08-04 10:57 ` Li Zetao
2023-08-04 17:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230804102648.78683-1-hch@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizetao1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®