From: Xia Fukun <xiafukun@huawei.com>
To: <ilpo.jarvinen@linux.intel.com>, <andy.shevchenko@gmail.com>,
<gregkh@linuxfoundation.org>, <heikki.krogerus@linux.intel.com>
Cc: <xiafukun@huawei.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] serial: 8250_dw: Fix assignment error of data in dw8250_probe()
Date: Fri, 4 Aug 2023 20:16:07 +0800 [thread overview]
Message-ID: <20230804121607.191203-1-xiafukun@huawei.com> (raw)
When the "ri-override" property is present in the device,
data->msr_mask_on and UART_MSR_RI should be used for
OR-assignment. Fix the errors in it.
Fixes: 1bd8edba10e6 ("serial: 8250_dw: adapt to unified device property interface")
Signed-off-by: Xia Fukun <xiafukun@huawei.com>
---
drivers/tty/serial/8250/8250_dw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 7db51781289e..921b5f07828f 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -587,7 +587,7 @@ static int dw8250_probe(struct platform_device *pdev)
if (device_property_read_bool(dev, "ri-override")) {
/* Always report Ring indicator as inactive */
- data->msr_mask_off |= UART_MSR_RI;
+ data->msr_mask_on |= UART_MSR_RI;
data->msr_mask_off |= UART_MSR_TERI;
}
--
2.17.1
next reply other threads:[~2023-08-04 12:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 12:16 Xia Fukun [this message]
2023-08-04 12:24 ` Ilpo Järvinen
2023-08-04 12:41 ` Xia Fukun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230804121607.191203-1-xiafukun@huawei.com \
--to=xiafukun@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®