From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EEBEC001DE for ; Fri, 4 Aug 2023 17:58:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230130AbjHDR6Q (ORCPT ); Fri, 4 Aug 2023 13:58:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230055AbjHDR6E (ORCPT ); Fri, 4 Aug 2023 13:58:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2262449C3; Fri, 4 Aug 2023 10:58:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9CC9A620D0; Fri, 4 Aug 2023 17:58:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75C9EC433C7; Fri, 4 Aug 2023 17:57:59 +0000 (UTC) Date: Fri, 4 Aug 2023 13:57:57 -0400 From: Steven Rostedt To: Marco Elver Cc: Andrew Morton , Kees Cook , Guenter Roeck , Peter Zijlstra , Mark Rutland , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Nathan Chancellor , Nick Desaulniers , Tom Rix , Miguel Ojeda , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Dmitry Vyukov , Alexander Potapenko , kasan-dev@googlegroups.com, linux-toolchains@vger.kernel.org Subject: Re: [PATCH v2 2/3] list_debug: Introduce inline wrappers for debug checks Message-ID: <20230804135757.400eab72@gandalf.local.home> In-Reply-To: References: <20230804090621.400-1-elver@google.com> <20230804090621.400-2-elver@google.com> <20230804120308.253c5521@gandalf.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Aug 2023 19:49:48 +0200 Marco Elver wrote: > > I've been guilty of this madness myself, but I have learned the errors of > > my ways, and have been avoiding doing so in any new code I write. > > That's fair. We can call them __list_*_valid() (inline), and > __list_*_valid_or_report() ? __list_*_valid_check() ? -- Steve