From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7979C001DB for ; Sat, 5 Aug 2023 06:22:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229735AbjHEGW2 (ORCPT ); Sat, 5 Aug 2023 02:22:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjHEGW0 (ORCPT ); Sat, 5 Aug 2023 02:22:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80E7C4ED6; Fri, 4 Aug 2023 23:22:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 12DD760AD6; Sat, 5 Aug 2023 06:22:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 165CEC433C8; Sat, 5 Aug 2023 06:22:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691216543; bh=71bkMSZKOc3HbinOnFH6CrCi9MNzOVOiV++TgrRs0RU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=krCquNPUKYxEdMuc6EYEPY8FF+8qdVLpNWeGVb7Bi4Lvanzga1ZgzDz72YEobrbwa liuvHaUB7WeuMZh01GdVUCh0ERZtx5s/3eemeuDuGdkY8XOl8D6uCxaLuSjVBpsZ3V bgyiYsgmXq2Nj4T1/pcvMARjJCAxLZMT2KMu2CMg= Date: Sat, 5 Aug 2023 08:22:20 +0200 From: Greg KH To: coolrrsh@gmail.com Cc: broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH v2] fixes warning Message-ID: <2023080507-umbrella-automated-0db9@gregkh> References: <20230804200711.65750-1-coolrrsh@gmail.com> <20230804200711.65750-2-coolrrsh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230804200711.65750-2-coolrrsh@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 05, 2023 at 01:37:11AM +0530, coolrrsh@gmail.com wrote: > From: Rajeshwar R Shinde > > Typecasting the interrupt number from "unsigned int" to "signed int" to compare with 0(signed int by default). > Declaring interrupt number as "signed int" would violate kernel standards. So typecasting is the possible approach. > The fix is for spi-mpc52xx. > > This fixes warning such as: > drivers/spi/spi-mpc52xx-psc.c:332:5-13: WARNING: Unsigned expression compared with zero: mps -> irq < 0 > > Signed-off-by: Rajeshwar R Shinde > --- > drivers/spi/spi-mpc52xx-psc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Your subject lines are still incorrect :(