From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB58DC00528 for ; Sat, 5 Aug 2023 09:59:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229921AbjHEJ7y (ORCPT ); Sat, 5 Aug 2023 05:59:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjHEJ7w (ORCPT ); Sat, 5 Aug 2023 05:59:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2522E1B9; Sat, 5 Aug 2023 02:59:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9157A60C2D; Sat, 5 Aug 2023 09:59:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70219C433C7; Sat, 5 Aug 2023 09:59:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691229590; bh=8pq7Mvx+TRA12e4vFW91N0Mh0e3g8VjFd8UdpQ7QWYs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AgcdIwDBvGLn+mxO03OE/JR0v6I0If8yACOK6+4PIJRIYFcsNzrrQV7h8UcP0LN/t 0fCKoOsW8l/Rib2JcR9XUSn4+sBlNYLBX992RGl0Po7lx/75irYdRnuD8MLdbDchln T6xDlSfTCdOSODNTRc8zU7DeXqbVbTLw2w1oEmFk= Date: Sat, 5 Aug 2023 11:59:47 +0200 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: Heikki Krogerus , Rajat Khandelwal , Arnd Bergmann , Neil Armstrong , Bjorn Andersson , Dmitry Baryshkov , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: typec: intel_pmc_mux: select CONFIG_USB_COMMON Message-ID: <2023080514-mothball-chaps-2b42@gregkh> References: <20230805095157.3459892-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230805095157.3459892-1-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 05, 2023 at 11:51:53AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > It is possible to configure the typec drivers to be built-in while the > actual USB host and device support is in loadable modules, but that now > causes a link failure because the usb debugfs support is then not > available to built-in code. > > x86_64-linux-ld: drivers/usb/typec/mux/intel_pmc_mux.o: in function `pmc_usb_init': > intel_pmc_mux.c:(.init.text+0x3): undefined reference to `usb_debug_root' > > Select CONFIG_USB_COMMON to get it to build again, as we do for > other drivers that require the core usb functionality. > > Fixes: 0a453dc9f2602 ("usb: typec: intel_pmc_mux: Expose IOM port status to debugfs") > Signed-off-by: Arnd Bergmann > --- > drivers/usb/typec/mux/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig > index 784b9d8107e9b..65da61150ba78 100644 > --- a/drivers/usb/typec/mux/Kconfig > +++ b/drivers/usb/typec/mux/Kconfig > @@ -29,6 +29,7 @@ config TYPEC_MUX_INTEL_PMC > tristate "Intel PMC mux control" > depends on ACPI > depends on INTEL_SCU_IPC > + select USB_COMMON > select USB_ROLE_SWITCH > help > Driver for USB muxes controlled by Intel PMC FW. Intel PMC FW can > -- > 2.39.2 > I think this is already fixed by commit ef7c4d8a90c6 ("usb: typec: mux: intel: Add dependency on USB_COMMON") in my tree and will be in the next linux-next release on Monday. thanks, greg k-h