From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06B35C00528 for ; Sat, 5 Aug 2023 17:23:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229974AbjHERXi (ORCPT ); Sat, 5 Aug 2023 13:23:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjHERXg (ORCPT ); Sat, 5 Aug 2023 13:23:36 -0400 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D1A6A6; Sat, 5 Aug 2023 10:23:35 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 375HNPlx031530; Sat, 5 Aug 2023 12:23:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691256205; bh=hZBwlg14xih624c/A24lGt3GF8niDIXlMd6SqBRp/qY=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=FkfVU/WMyQtHuJE5IyKo9dBwbV/ZpTF8CEr5vOgaffgH1RQkuYwTja6qAmfk8FwN2 z30h8dmRaxPxRx4flFd5R/N/BJLbr67reELoO20ZRu195NuEB2tcr7nr0X6cZbjpo0 naP3cH1SQborXDT4g5KUwtDfJC1XaZ/b4u7SSWJw= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 375HNPXB004364 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 5 Aug 2023 12:23:25 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Sat, 5 Aug 2023 12:23:25 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Sat, 5 Aug 2023 12:23:25 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 375HNP9d051940; Sat, 5 Aug 2023 12:23:25 -0500 Date: Sat, 5 Aug 2023 12:23:25 -0500 From: Nishanth Menon To: Dhruva Gole CC: Tony Lindgren , , "Dave Gerlach" , Faiz Abbas , "Greg Kroah-Hartman" , Keerthy , "Kevin Hilman" , , Subject: Re: [PATCH 1/3] bus: ti-sysc: Fix build warning for 64-bit build Message-ID: <20230805172325.4vjb4lb3vtu3dgfe@commodity> References: <20230804103859.57458-1-tony@atomide.com> <20230805051753.vpwhg52zttpbbntx@dhruva> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230805051753.vpwhg52zttpbbntx@dhruva> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10:47-20230805, Dhruva Gole wrote: > Hi Tony, > > On Aug 04, 2023 at 13:38:57 +0300, Tony Lindgren wrote: > > Fix "warning: cast from pointer to integer of different size" on 64-bit > > builds. > > Thanks for enabling this on 64 bit, will help us in K3 SOCs. > > > > > Note that this is a cosmetic fix at this point as the driver is not yet > > used for 64-bit systems. > > > > Fixes: feaa8baee82a ("bus: ti-sysc: Implement SoC revision handling") > > Signed-off-by: Tony Lindgren > > --- > > drivers/bus/ti-sysc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c > > --- a/drivers/bus/ti-sysc.c > > +++ b/drivers/bus/ti-sysc.c > > @@ -3104,7 +3104,7 @@ static int sysc_init_static_data(struct sysc *ddata) > > > > match = soc_device_match(sysc_soc_match); > > if (match && match->data) > > - sysc_soc->soc = (int)match->data; > > + sysc_soc->soc = (unsigned long)match->data; > > Reviewed-by: Dhruva Gole Dumb q: is'nt this an enum? Is it better to cast it as (enum sysc_soc)match->data ? > > > > > /* > > * Check and warn about possible old incomplete dtb. We now want to see > > -- > > 2.41.0 > > -- > Best regards, > Dhruva Gole -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D