mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lecopzer Chen <lecopzer.chen@mediatek.com>
To: <lecopzer.chen@mediatek.com>
Cc: <arnd@arndb.de>, <linus.walleij@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux@armlinux.org.uk>,
	<yj.chiang@mediatek.com>
Subject: Re: [PATCH] ARM: ptrace: fix scno of -1 cause SIGILL
Date: Mon, 7 Aug 2023 15:53:09 +0800	[thread overview]
Message-ID: <20230807075309.6188-1-lecopzer.chen@mediatek.com> (raw)
In-Reply-To: <20230724121655.7894-1-lecopzer.chen@mediatek.com>


> In commit [1], the -1 scno is used as a special scno when the task's
> syscall is traced.

> After commit [2], PTRACE_SET_SYSCALL will always mask syscall with
> __NR_SYSCALL_MASK, this makes the condition `cmp scno, #-1` broken,
> and some test like Android VTS[3] is also failed because SIGILL
> interrupt the test program.

> Let's test with `and` logic with #0x0ff000. Instead of #__NR_SYSCALL_MASK
> because of the constraint of ARM Operand2 rules and avoid conflicting
> with ARM private syscall.

...

Please follow the commit from Kees below and ignore this patch, thanks.

https://lore.kernel.org/all/20230804071045.never.134-kees@kernel.org/



      reply	other threads:[~2023-08-07  7:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-24 12:16 Lecopzer Chen
2023-08-07  7:53 ` Lecopzer Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230807075309.6188-1-lecopzer.chen@mediatek.com \
    --to=lecopzer.chen@mediatek.com \
    --cc=arnd@arndb.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=yj.chiang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®