From: menglong8.dong@gmail.com
To: edumazet@google.com, ncardwell@google.com
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
dsahern@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Menglong Dong <imagedong@tencent.com>
Subject: [PATCH net-next v2 0/3]net: tcp: support probing OOM
Date: Mon, 7 Aug 2023 21:45:44 +0800 [thread overview]
Message-ID: <20230807134547.2782227-1-imagedong@tencent.com> (raw)
From: Menglong Dong <imagedong@tencent.com>
In this series, we make some small changes to make the tcp retransmission
become zero-window probes if the receiver drops the skb because of memory
pressure.
In the 1st patch, we reply a zero-window ACK if the skb is dropped
because out of memory, instead of dropping the skb silently.
In the 2nd patch, we allow a zero-window ACK to update the window.
In the 3rd patch, we check the timeout of a probing socket with
'(u32)icsk->icsk_timeout', instead of 'tcp_jiffies32'. This is more like
a bugfix.
After these changes, the tcp can probe the OOM of the receiver forever.
Changes since v1:
- send 0 rwin ACK for the receive queue empty case when necessary in the
1st patch
- send the ACK immediately by using the ICSK_ACK_NOW flag in the 1st
patch
- consider the case of the connection restart from idle, as Neal comment,
in the 3rd patch
Menglong Dong (3):
net: tcp: send zero-window ACK when no memory
net: tcp: allow zero-window ACK update the window
net: tcp: fix unexcepted socket die when snd_wnd is 0
include/net/inet_connection_sock.h | 3 ++-
net/ipv4/tcp_input.c | 16 ++++++++++++----
net/ipv4/tcp_output.c | 14 +++++++++++---
net/ipv4/tcp_timer.c | 10 +++++++++-
4 files changed, 34 insertions(+), 9 deletions(-)
--
2.40.1
next reply other threads:[~2023-08-07 13:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 13:45 menglong8.dong [this message]
2023-08-07 13:45 ` [PATCH net-next v2 1/3] net: tcp: send zero-window ACK when no memory menglong8.dong
2023-08-07 14:05 ` Eric Dumazet
2023-08-08 1:58 ` Menglong Dong
2023-08-07 13:45 ` [PATCH net-next v2 2/3] net: tcp: allow zero-window ACK update the window menglong8.dong
2023-08-07 13:45 ` [PATCH net-next v2 3/3] net: tcp: fix unexcepted socket die when snd_wnd is 0 menglong8.dong
2023-08-07 14:19 ` Eric Dumazet
2023-08-08 2:05 ` Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807134547.2782227-1-imagedong@tencent.com \
--to=menglong8.dong@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=imagedong@tencent.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®