From: Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
To: jirislaby@kernel.org, mickflemm@gmail.com, mcgrof@kernel.org,
kvalo@kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
Subject: [PATCH] ath5k: fix WARNING opportunity for swap.
Date: Tue, 8 Aug 2023 00:10:57 +0400 [thread overview]
Message-ID: <20230807201057.340371-1-mahmoudmatook.mm@gmail.com> (raw)
coccinielle reported the following:
./drivers/net/wireless/ath/ath5k/phy.c:1573:25-26: WARNING opportunity for swap()
Signed-off-by: Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
---
drivers/net/wireless/ath/ath5k/phy.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
index 5797ef9c73d7..f87eb684f223 100644
--- a/drivers/net/wireless/ath/ath5k/phy.c
+++ b/drivers/net/wireless/ath/ath5k/phy.c
@@ -1562,16 +1562,13 @@ static s16
ath5k_hw_get_median_noise_floor(struct ath5k_hw *ah)
{
s16 sort[ATH5K_NF_CAL_HIST_MAX];
- s16 tmp;
int i, j;
memcpy(sort, ah->ah_nfcal_hist.nfval, sizeof(sort));
for (i = 0; i < ATH5K_NF_CAL_HIST_MAX - 1; i++) {
for (j = 1; j < ATH5K_NF_CAL_HIST_MAX - i; j++) {
if (sort[j] > sort[j - 1]) {
- tmp = sort[j];
- sort[j] = sort[j - 1];
- sort[j - 1] = tmp;
+ swap(sort[j], sort[j - 1]);
}
}
}
--
2.34.1
next reply other threads:[~2023-08-07 20:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 20:10 Mahmoud Maatuq [this message]
2023-08-08 6:02 ` Jiri Slaby
2023-08-08 19:42 ` Mahmoud Matook
2023-08-09 10:40 ` Jiri Slaby
2023-08-12 4:57 ` Mahmoud Matook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807201057.340371-1-mahmoudmatook.mm@gmail.com \
--to=mahmoudmatook.mm@gmail.com \
--cc=jirislaby@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®