From: Hugo Villeneuve <hugo@hugovil.com>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: <agk@redhat.com>, <snitzer@kernel.org>, <dm-devel@redhat.com>,
<heinzm@redhat.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] dm: Remove unused declaration dm_get_rq_mapinfo()
Date: Tue, 8 Aug 2023 13:03:33 -0400 [thread overview]
Message-ID: <20230808130333.2207c675d008fa6c808a472f@hugovil.com> (raw)
In-Reply-To: <20230808150301.45196-1-yuehaibing@huawei.com>
On Tue, 8 Aug 2023 23:03:01 +0800
Yue Haibing <yuehaibing@huawei.com> wrote:
Hi,
> Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()")
> removed the implementation but leave declaration.
Maybe change to "removed the implementation but not the declaration."
Hugo Villeneuve.
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> include/linux/device-mapper.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h
> index 69d0435c7ebb..5bc69c6a64e0 100644
> --- a/include/linux/device-mapper.h
> +++ b/include/linux/device-mapper.h
> @@ -502,7 +502,6 @@ int dm_post_suspending(struct dm_target *ti);
> int dm_noflush_suspending(struct dm_target *ti);
> void dm_accept_partial_bio(struct bio *bio, unsigned int n_sectors);
> void dm_submit_bio_remap(struct bio *clone, struct bio *tgt_clone);
> -union map_info *dm_get_rq_mapinfo(struct request *rq);
>
> #ifdef CONFIG_BLK_DEV_ZONED
> struct dm_report_zones_args {
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-08-08 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 15:03 Yue Haibing
2023-08-08 17:03 ` Hugo Villeneuve [this message]
2023-08-09 3:03 ` Yue Haibing
2024-08-01 13:31 Yue Haibing
2024-08-02 0:48 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230808130333.2207c675d008fa6c808a472f@hugovil.com \
--to=hugo@hugovil.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=heinzm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®