From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B258C001B0 for ; Tue, 8 Aug 2023 17:55:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233888AbjHHRzl (ORCPT ); Tue, 8 Aug 2023 13:55:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231529AbjHHRzN (ORCPT ); Tue, 8 Aug 2023 13:55:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC46C2988C for ; Tue, 8 Aug 2023 09:24:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D5982626B7 for ; Tue, 8 Aug 2023 16:24:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEDE8C433C7; Tue, 8 Aug 2023 16:24:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691511855; bh=E5Y/HlpzHmIcdubESa/a/Dmm+Rjpvc/XYS+aTQw6OAI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EMiwfsJsApEtWj808nlctc2cCoW1Bg3jlfmp6RHGNjxuPL6WixxakoXT6JNIT7qkf eX5fzJi3p6tscVGSVylutzC5xYQMnL2oymedPZaoabQ6YgtVDq8YTxh9fHOkzQVwbx iRKprPP/DmjKNe6ikTJjBKAs0JCVHIKAgwRFy2Kwaso9MLXR075qjA1LohSmli9HCJ +AFyS+uigsll1MNyTttCmCfmnGk4L4ldfCUSbY3vxFT8owG7KFaNIc89Tx7ky982bl GGRvmNiQ8Z3gv+ItRThSRxRrJXZHRYZ+7/ReuB2XSK7+qIzs701bsEf96EnY3kik1N CX2Y7fuF8nrrA== Date: Tue, 8 Aug 2023 09:24:12 -0700 From: Nathan Chancellor To: Nick Desaulniers Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Tom Rix , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, kernel test robot Subject: Re: [PATCH] riscv: mm: fix 2 instances of -Wmissing-variable-declarations Message-ID: <20230808162412.GA2172017@dev-arch.thelio-3990X> References: <20230808-riscv_static-v1-1-9f3dc99dafe8@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230808-riscv_static-v1-1-9f3dc99dafe8@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 08, 2023 at 09:15:41AM -0700, Nick Desaulniers wrote: > I'm looking to enable -Wmissing-variable-declarations behind W=1. 0day > bot spotted the following instance in ARCH=riscv builds: > > arch/riscv/mm/init.c:276:7: warning: no previous extern declaration > for non-static variable 'trampoline_pg_dir' > [-Wmissing-variable-declarations] > 276 | pgd_t trampoline_pg_dir[PTRS_PER_PGD] __page_aligned_bss; > | ^ > arch/riscv/mm/init.c:276:1: note: declare 'static' if the variable is > not intended to be used outside of this translation unit > 276 | pgd_t trampoline_pg_dir[PTRS_PER_PGD] __page_aligned_bss; > | ^ > arch/riscv/mm/init.c:279:7: warning: no previous extern declaration > for non-static variable 'early_pg_dir' > [-Wmissing-variable-declarations] > 279 | pgd_t early_pg_dir[PTRS_PER_PGD] __initdata __aligned(PAGE_SIZE); > | ^ > arch/riscv/mm/init.c:279:1: note: declare 'static' if the variable is > not intended to be used outside of this translation unit > 279 | pgd_t early_pg_dir[PTRS_PER_PGD] __initdata __aligned(PAGE_SIZE); > | ^ > > These symbols are referenced by more than one translation unit, so make > sure they're both declared and include the correct header for their > declarations. Finally, sort the list of includes to help keep them tidy. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/llvm/202308081000.tTL1ElTr-lkp@intel.com/ > Signed-off-by: Nick Desaulniers > --- > arch/riscv/include/asm/pgtable.h | 1 + > arch/riscv/mm/init.c | 9 +++++---- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h > index 75970ee2bda2..4c8c0f83a974 100644 > --- a/arch/riscv/include/asm/pgtable.h > +++ b/arch/riscv/include/asm/pgtable.h > @@ -188,6 +188,7 @@ extern struct pt_alloc_ops pt_ops __initdata; > #define PAGE_KERNEL_IO __pgprot(_PAGE_IOREMAP) > > extern pgd_t swapper_pg_dir[]; > +extern pgd_t trampoline_pg_dir[]; Missing early_pg_dir too? It looks like there is already a declaration in arch/riscv/mm/kasan_init.c that could be hoisted here? > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > static inline int pmd_present(pmd_t pmd) > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index 9ce504737d18..cc0e06b4f223 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -26,12 +26,13 @@ > #include > > #include > -#include > -#include > -#include > #include > -#include > #include > +#include > +#include > +#include > +#include > +#include > > #include "../kernel/head.h" > > > --- > base-commit: 14f9643dc90adea074a0ffb7a17d337eafc6a5cc > change-id: 20230808-riscv_static-348036edcae7 > > Best regards, > -- > Nick Desaulniers >