Re: [PATCH] serial: core: Revert port_id use

[Dhruva Gole <d-gole@ti.com>]

On Aug 09, 2023 at 08:26:50 +0300, Tony Lindgren wrote:
> Hi,
> 
> * Guenter Roeck <linux@roeck-us.net> [230806 13:19]:
> > On Sun, Aug 06, 2023 at 09:20:50AM +0300, Tony Lindgren wrote:
> > > Guenter reports boot issues with duplicate sysfs entries for multiport
> > > drivers. Let's go back to using port->line for now to fix the regression.
> > > 
> > > With this change, the serial core port device names are not correct for the
> > > hardware specific 8250 single port drivers, but that's a cosmetic issue for
> > > now.
> > > 
> > > Fixes: d962de6ae51f ("serial: core: Fix serial core port id to not use port->line")
> > > Reported-by: Guenter Roeck <groeck7@gmail.com>
> > > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > 
> > Tested-by: Guenter Roeck <linux@roeck-us.net>
> 
> Thanks for testing.
> 
> Guenter, care to also test the patch below on top of this fix and
> see if things still behave for you?
> 
> I'll send a proper patch assuming things test fine.
> 
> Regagrds,
> 
> Tony
> 
> 8< --------------------
> diff --git a/drivers/tty/serial/serial_base.h b/drivers/tty/serial/serial_base.h
> --- a/drivers/tty/serial/serial_base.h
> +++ b/drivers/tty/serial/serial_base.h
> @@ -16,6 +16,7 @@ struct device;
>  
>  struct serial_ctrl_device {
>  	struct device dev;
> +	struct ida ida;

When you send the proper patch, might want to change variable name to
something other than ida?

[...]
>  
> -- 
> 2.41.0

-- 
Best regards,
Dhruva Gole <d-gole@ti.com>