From: Stefan Hajnoczi <stefanha@redhat.com>
To: kvm@vger.kernel.org
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
"Tian, Kevin" <kevin.tian@intel.com>,
linux-kernel@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [PATCH 0/4] vfio: use __aligned_u64 for ioctl structs
Date: Wed, 9 Aug 2023 17:02:44 -0400 [thread overview]
Message-ID: <20230809210248.2898981-1-stefanha@redhat.com> (raw)
Jason Gunthorpe <jgg@ziepe.ca> pointed out that u64 VFIO ioctl struct fields
have architecture-dependent alignment. iommufd already uses __aligned_u64 to
avoid this problem.
Reasons for using __aligned_u64 include avoiding potential information leaks
due to architecture-specific holes in structs and 32-bit userspace on 64-bit
kernel ioctl compatibility issues. See the __aligned_u64 typedef in
<uapi/linux/types.h> for details.
This series modifies the VFIO ioctl structs to use __aligned_u64. Some of the
changes preserve the existing memory layout on all architectures, so I put them
together into the first patch. The remaining patches are for structs where
explanation is necessary about why changing the memory layout does not break
the uapi.
Stefan Hajnoczi (4):
vfio: trivially use __aligned_u64 for ioctl structs
vfio: use __aligned_u64 in struct vfio_device_gfx_plane_info
vfio: use __aligned_u64 in struct vfio_iommu_type1_info
vfio: use __aligned_u64 in struct vfio_device_ioeventfd
include/uapi/linux/vfio.h | 27 +++++++++++++++------------
drivers/gpu/drm/i915/gvt/kvmgt.c | 4 +++-
drivers/vfio/vfio_iommu_type1.c | 11 ++---------
samples/vfio-mdev/mbochs.c | 6 ++++--
samples/vfio-mdev/mdpy.c | 4 +++-
5 files changed, 27 insertions(+), 25 deletions(-)
--
2.41.0
next reply other threads:[~2023-08-09 21:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 21:02 Stefan Hajnoczi [this message]
2023-08-09 21:02 ` [PATCH 1/4] vfio: trivially " Stefan Hajnoczi
2023-08-14 17:47 ` Jason Gunthorpe
2023-08-09 21:02 ` [PATCH 2/4] vfio: use __aligned_u64 in struct vfio_device_gfx_plane_info Stefan Hajnoczi
2023-08-10 3:22 ` Tian, Kevin
2023-08-10 14:24 ` Stefan Hajnoczi
2023-08-15 12:38 ` Stefan Hajnoczi
2023-08-14 17:50 ` Jason Gunthorpe
2023-08-15 12:38 ` Stefan Hajnoczi
2023-08-15 15:23 ` David Laight
2023-08-16 13:36 ` Stefan Hajnoczi
2023-08-09 21:02 ` [PATCH 3/4] vfio: use __aligned_u64 in struct vfio_iommu_type1_info Stefan Hajnoczi
2023-08-10 3:25 ` Tian, Kevin
2023-08-10 14:25 ` Stefan Hajnoczi
2023-08-14 17:52 ` Jason Gunthorpe
2023-08-09 21:02 ` [PATCH 4/4] vfio: use __aligned_u64 in struct vfio_device_ioeventfd Stefan Hajnoczi
2023-08-14 17:52 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230809210248.2898981-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®