From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 555B9C001E0 for ; Thu, 10 Aug 2023 13:22:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235176AbjHJNW1 (ORCPT ); Thu, 10 Aug 2023 09:22:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234563AbjHJNWZ (ORCPT ); Thu, 10 Aug 2023 09:22:25 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5A3226BA; Thu, 10 Aug 2023 06:22:24 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 87C491F45B; Thu, 10 Aug 2023 13:22:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1691673743; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ip4/n/Ixm1Bk8FuN4QHn1uJbC9drYLK9GfOJr4AAEtM=; b=BxZn5CuV7wSpq0tyhpXX46wxkC2eNhpvXtx+4SQAFpJ9pyye7By5GEEIEfZKNGGEQE6JsB 7eWPID76Yfe8zcKuuGvCFoi6OQXj+UFFnF5q3oQPQcN7OTcyHYBi8RHG5YL/n4BTpIko7U Tmo3/RhJ+l6WQoLcKvmo7+XmOISCrfg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1691673743; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ip4/n/Ixm1Bk8FuN4QHn1uJbC9drYLK9GfOJr4AAEtM=; b=hZgJnbzJyp/A1AEZ80ZKTjDXrhIyKheFLlnGkTPjjeBvRLc/clNMuNeIEKUlwbW17I76ym sGmnBRPav34yKgBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 76CA6138E2; Thu, 10 Aug 2023 13:22:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9LoYHY/k1GQLaQAAMHmgww (envelope-from ); Thu, 10 Aug 2023 13:22:23 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id E5E1BA076F; Thu, 10 Aug 2023 15:22:22 +0200 (CEST) Date: Thu, 10 Aug 2023 15:22:22 +0200 From: Jan Kara To: Jeff Layton Cc: Christian Brauner , OGAWA Hirofumi , Frank Sorenson , Jan Kara , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/2] fat: make fat_update_time get its own timestamp Message-ID: <20230810132222.vzz5mqu3r64tz4yr@quack3> References: <20230810-ctime-fat-v1-0-327598fd1de8@kernel.org> <20230810-ctime-fat-v1-2-327598fd1de8@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230810-ctime-fat-v1-2-327598fd1de8@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 10-08-23 09:12:05, Jeff Layton wrote: > In later patches, we're going to drop the "now" parameter from the > update_time operation. Fix fat_update_time to fetch its own timestamp. > It turns out that this is easily done by just passing a NULL timestamp > pointer to fat_truncate_time. > > Signed-off-by: Jeff Layton Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/fat/misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/fat/misc.c b/fs/fat/misc.c > index 37f4afb346af..f2304a1054aa 100644 > --- a/fs/fat/misc.c > +++ b/fs/fat/misc.c > @@ -347,7 +347,7 @@ int fat_update_time(struct inode *inode, int flags) > return 0; > > if (flags & (S_ATIME | S_CTIME | S_MTIME)) { > - fat_truncate_time(inode, now, flags); > + fat_truncate_time(inode, NULL, flags); > if (inode->i_sb->s_flags & SB_LAZYTIME) > dirty_flags |= I_DIRTY_TIME; > else > > -- > 2.41.0 > -- Jan Kara SUSE Labs, CR