From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF75AC001B0 for ; Fri, 11 Aug 2023 11:55:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233618AbjHKLzP (ORCPT ); Fri, 11 Aug 2023 07:55:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229927AbjHKLzN (ORCPT ); Fri, 11 Aug 2023 07:55:13 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BAFE10F for ; Fri, 11 Aug 2023 04:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1691754913; x=1723290913; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wkQiXD5lhHC4BlkyLDnM817+Xs35EEJIrj//vDXJ1+E=; b=RGJ6fQeNMFePoIhNZryeBwT6zFMQnZQfxVsqabvUyOanBXdLUYDfBJPi oRRd0LXbHRS8lOLmWShg9wezElLof+jqq+VFigvyjYt/xv0DlbpNke9Jf ExasImZD8iXJioUIP8wj51C+IhsczWp7m7RNwaL7Y5hATvW1er+3ptEr9 v8jRVdAI0hKrUYakR4T68A80Q3yxihLwGHDBAN59bRxcJOkK4f1XMqFqE M3gGBKO5I9xi9akISy4UGNb0m5mHBrvCg2lvZeWB/XsFXKWCBHZCan1sv ZEwEyRifmL1WoZa5/NOLYcF/BlKLfExAfFVCK0k4K/V3bWU8pHb7sY64t g==; X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="asc'?scan'208";a="241105573" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 11 Aug 2023 04:55:12 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 11 Aug 2023 04:55:06 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Fri, 11 Aug 2023 04:55:04 -0700 Date: Fri, 11 Aug 2023 12:54:26 +0100 From: Conor Dooley To: Alexandre Ghiti CC: Alexandre Ghiti , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alan Kao , , , Bo YU , Aurelien Jarno Subject: Re: [PATCH -fixes] riscv: uaccess: Return the number of bytes effectively copied Message-ID: <20230811-overture-catnip-2b004303cbc5@wendy> References: <20230811110304.1613032-1-alexghiti@rivosinc.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="utvI2jTqZvG5HlnU" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --utvI2jTqZvG5HlnU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 11, 2023 at 01:39:16PM +0200, Alexandre Ghiti wrote: > On 11/08/2023 13:03, Alexandre Ghiti wrote: > > It was reported that the riscv kernel hangs while executing the test > > in [1]. > >=20 > > Indeed, the test hangs when trying to write a buffer to a file. The > > problem is that the riscv implementation of raw_copy_from_user() does n= ot > > return the number of bytes written when an exception happens and is fix= ed > > up. >=20 >=20 > I'll respin another version as the changelog and the title are incorrect: > the uaccess routines should not return the number of bytes copied but > actually the number of bytes not copied (this is what this patch > implements). >=20 > I'll wait for feedbacks before doing so! While you're editing te changelog, can you make the link a regular Link: tag? You can do `Link: [1]`. --utvI2jTqZvG5HlnU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZNYhcgAKCRB4tDGHoIJi 0hKBAQCQBCxeWgLbOKa053boEyjUTJSr9hF6K1Lz9DQbnvSa9AD/Tow8dsW2O5Nh xIRwuL7H4GhlsBa32V3l2JqT/gkP7Q8= =Dq+D -----END PGP SIGNATURE----- --utvI2jTqZvG5HlnU--