From: menglong8.dong@gmail.com
To: edumazet@google.com, ncardwell@google.com
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
dsahern@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, flyingpeng@tencent.com,
Menglong Dong <imagedong@tencent.com>
Subject: [PATCH net-next v4 0/4] net: tcp: support probing OOM
Date: Fri, 11 Aug 2023 10:55:26 +0800 [thread overview]
Message-ID: <20230811025530.3510703-1-imagedong@tencent.com> (raw)
From: Menglong Dong <imagedong@tencent.com>
In this series, we make some small changes to make the tcp retransmission
become zero-window probes if the receiver drops the skb because of memory
pressure.
In the 1st patch, we reply a zero-window ACK if the skb is dropped
because out of memory, instead of dropping the skb silently.
In the 2nd patch, we allow a zero-window ACK to update the window.
In the 3rd patch, fix unexcepted socket die when snd_wnd is 0 in
tcp_retransmit_timer().
In the 4th patch, we refactor the debug message in tcp_retransmit_timer()
to make it more correct.
After these changes, the tcp can probe the OOM of the receiver forever.
Changes since v3:
- make the timeout "2 * TCP_RTO_MAX" in the 3rd patch
- tp->retrans_stamp is not based on jiffies and can't be compared with
icsk->icsk_timeout in the 3rd patch. Fix it.
- introduce the 4th patch
Changes since v2:
- refactor the code to avoid code duplication in the 1st patch
- use after() instead of max() in tcp_rtx_probe0_timed_out()
Changes since v1:
- send 0 rwin ACK for the receive queue empty case when necessary in the
1st patch
- send the ACK immediately by using the ICSK_ACK_NOW flag in the 1st
patch
- consider the case of the connection restart from idle, as Neal comment,
in the 3rd patch
Menglong Dong (4):
net: tcp: send zero-window ACK when no memory
net: tcp: allow zero-window ACK update the window
net: tcp: fix unexcepted socket die when snd_wnd is 0
net: tcp: refactor the dbg message in tcp_retransmit_timer()
include/net/inet_connection_sock.h | 3 ++-
net/ipv4/tcp_input.c | 20 ++++++++++-----
net/ipv4/tcp_output.c | 14 +++++++---
net/ipv4/tcp_timer.c | 41 ++++++++++++++++++++++--------
4 files changed, 56 insertions(+), 22 deletions(-)
--
2.40.1
next reply other threads:[~2023-08-11 3:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 2:55 menglong8.dong [this message]
2023-08-11 2:55 ` [PATCH net-next v4 1/4] net: tcp: send zero-window ACK when no memory menglong8.dong
2023-08-11 7:37 ` Eric Dumazet
2023-08-11 2:55 ` [PATCH net-next v4 2/4] net: tcp: allow zero-window ACK update the window menglong8.dong
2023-08-11 7:37 ` Eric Dumazet
2023-08-11 2:55 ` [PATCH net-next v4 3/4] net: tcp: fix unexcepted socket die when snd_wnd is 0 menglong8.dong
2023-08-11 7:38 ` Eric Dumazet
2023-08-11 2:55 ` [PATCH net-next v4 4/4] net: tcp: refactor the dbg message in tcp_retransmit_timer() menglong8.dong
2023-08-11 7:38 ` Eric Dumazet
2023-08-11 7:39 ` [PATCH net-next v4 0/4] net: tcp: support probing OOM Eric Dumazet
2023-08-13 11:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811025530.3510703-1-imagedong@tencent.com \
--to=menglong8.dong@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=flyingpeng@tencent.com \
--cc=imagedong@tencent.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®