From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05873C001DB for ; Sat, 12 Aug 2023 07:29:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233798AbjHLH3o (ORCPT ); Sat, 12 Aug 2023 03:29:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229959AbjHLH3n (ORCPT ); Sat, 12 Aug 2023 03:29:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C40E41B5; Sat, 12 Aug 2023 00:29:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4CD9D61011; Sat, 12 Aug 2023 07:29:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 188A4C433C8; Sat, 12 Aug 2023 07:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691825385; bh=5mv/Qe6HbdjVE5i1Dz+Ml4OmoUQl8Eg1gB3kzSufA88=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aCcRDefgKUJyZTq4tgROwt3pVVTLBWA5KE5tfu9/cmJbuVvH/Mr3f2HwvIcPulXCT mpXC1pHmtmjXCyMkxeEY3rmYQvlQKajsx0wafciK2j9kmO3hPfypyhJo8rKjvkaOeg 31nYlPubA6eUxpOsCd0m5NMV1fBba4m5PNl7dVTc= Date: Sat, 12 Aug 2023 09:29:42 +0200 From: Greg KH To: Mirsad Todorovac Cc: linux-kernel@vger.kernel.org, Dan Carpenter , Takashi Iwai , Kees Cook , "Luis R . Rodriguez" , Brian Norris , stable@vger.kernel.org Subject: Re: [PATCH v4 1/1] test_fimware: return -ENOMEM instead of -ENOSPC on failed memory allocation Message-ID: <2023081213-reset-tadpole-fc94@gregkh> References: <20230812054346.168223-1-mirsad.todorovac@alu.unizg.hr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230812054346.168223-1-mirsad.todorovac@alu.unizg.hr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 12, 2023 at 07:43:47AM +0200, Mirsad Todorovac wrote: > [ Upstream commit 7dae593cd226a0bca61201cf85ceb9335cf63682 ] > > In a couple of situations like > > name = kstrndup(buf, count, GFP_KERNEL); > if (!name) > return -ENOSPC; > > the error is not actually "No space left on device", but "Out of memory". > > It is semantically correct to return -ENOMEM in all failed kstrndup() > and kzalloc() cases in this driver, as it is not a problem with disk > space, but with kernel memory allocator failing allocation. > > The semantically correct should be: > > name = kstrndup(buf, count, GFP_KERNEL); > if (!name) > return -ENOMEM; > > Cc: Dan Carpenter > Cc: Takashi Iwai > Cc: Kees Cook > Cc: Luis R. Rodriguez > Cc: Brian Norris > Cc: stable@vger.kernel.org # 4.14 > Fixes: c92316bf8e948 ("test_firmware: add batched firmware tests") > Fixes: 0a8adf584759c ("test: add firmware_class loader test") > Fixes: eb910947c82f9 ("test: firmware_class: add asynchronous request trigger") > Fixes: 061132d2b9c95 ("test_firmware: add test custom fallback trigger") > Link: https://lore.kernel.org/all/20230606070808.9300-1-mirsad.todorovac@alu.unizg.hr/ > Signed-off-by: Mirsad Todorovac > > [ This is the backport of the patch to 4.19 and 4.14 branches. There are no ] > [ semantic differences in the commit. Backport is provided for completenes sake ] > [ so it would apply to all of the supported LTS kernels ] This commit is already in the 4.19.291 release, does it need to be included in there again for some reason? thanks, greg k-h