From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Chuang Wang <nashuiliang@gmail.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tracing/eprobe: Iterate trace_eprobe directly
Date: Sat, 12 Aug 2023 14:20:19 +0900 [thread overview]
Message-ID: <20230812142019.06cb38b56287b0f068e8164f@kernel.org> (raw)
In-Reply-To: <20230811154523.61e67cc3@gandalf.local.home>
On Fri, 11 Aug 2023 15:45:23 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Fri, 11 Aug 2023 16:12:39 +0800
> Chuang Wang <nashuiliang@gmail.com> wrote:
>
> > +
> > +#define for_each_trace_eprobe_on_trace_probe(ep, _tp) \
> > + list_for_each_entry(ep, trace_probe_probe_list(_tp), tp.list)
> > +
>
> As I replied to the other patch, but after this one was sent (sorry, I was
> hyperfocused on my work the last couple of days and was not reading email,
> so my INBOX is a bit full). I really hate the verbosity of that name.
>
> At a minimum, let's call it:
>
> for_each_trace_point_eprobe()
OK, what about "for_each_trace_eprobe_on()"? I would like to clarify
- what type is returned
- not all trace_eprobes, but only on the trace_probe.
Thank you,
>
> -- Steve
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2023-08-12 5:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 8:12 Chuang Wang
2023-08-11 11:48 ` Masami Hiramatsu
2023-08-11 19:45 ` Steven Rostedt
2023-08-12 5:20 ` Masami Hiramatsu [this message]
2023-08-16 20:08 ` Steven Rostedt
2023-08-18 11:02 ` Masami Hiramatsu
2023-08-18 11:42 ` chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230812142019.06cb38b56287b0f068e8164f@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=nashuiliang@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®