From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD9F3C001DB for ; Sun, 13 Aug 2023 16:01:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230304AbjHMQBf (ORCPT ); Sun, 13 Aug 2023 12:01:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231360AbjHMQBV (ORCPT ); Sun, 13 Aug 2023 12:01:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45A861710; Sun, 13 Aug 2023 09:01:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3280860B38; Sun, 13 Aug 2023 16:00:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56B98C433C8; Sun, 13 Aug 2023 16:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691942420; bh=uewy2yNn9F65oLxAQMXFZszdhFU20SCYbOo+3oaOn84=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dJjWWBHHhK3HJ+G+tPftudfB87st7G4Hze3jhl1S5qRNoXGNJb55E4TXRRXmX/Eqs JtieS2kRjd37w3mdMZz6Clnx9YkPZnowcPRrAa/T3/FMRR+d+yd10cQ93MOGBRJoUI BnMny737/UPi3O+9RpEwEEFLBnOQEhmMYLnPoVTFRpmbz/G1bBfC3MNHC66D7TRwAX Tf9ZEYF0kRt7oB2XfNEMeUHpsfZ7HdivA7/npMQEPCPu98Ad0MJSRpxUrrrQ500Pht Q0TeNytPLvgSwD/jOldimcDL7MX8gxhgu57b7wFuJuJiy4NYMsxbVzKjA3GNB5WMoi W5/SYda8RCTjA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alexander Stein , ming_qian , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , shijie.qin@nxp.com, eagle.zhou@nxp.com, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 03/47] media: amphion: use dev_err_probe Date: Sun, 13 Aug 2023 11:58:58 -0400 Message-Id: <20230813160006.1073695-3-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230813160006.1073695-1-sashal@kernel.org> References: <20230813160006.1073695-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.45 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Stein [ Upstream commit 517f088385e1b8015606143e6212cb30f8714070 ] This simplifies the code and silences -517 error messages. Also the reason is listed in /sys/kernel/debug/devices_deferred. Signed-off-by: Alexander Stein Reviewed-by: ming_qian Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/amphion/vpu_mbox.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/amphion/vpu_mbox.c b/drivers/media/platform/amphion/vpu_mbox.c index bf759eb2fd46d..b6d5b4844f672 100644 --- a/drivers/media/platform/amphion/vpu_mbox.c +++ b/drivers/media/platform/amphion/vpu_mbox.c @@ -46,11 +46,10 @@ static int vpu_mbox_request_channel(struct device *dev, struct vpu_mbox *mbox) cl->rx_callback = vpu_mbox_rx_callback; ch = mbox_request_channel_byname(cl, mbox->name); - if (IS_ERR(ch)) { - dev_err(dev, "Failed to request mbox chan %s, ret : %ld\n", - mbox->name, PTR_ERR(ch)); - return PTR_ERR(ch); - } + if (IS_ERR(ch)) + return dev_err_probe(dev, PTR_ERR(ch), + "Failed to request mbox chan %s\n", + mbox->name); mbox->ch = ch; return 0; -- 2.40.1