From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 126C5C001DE for ; Sun, 13 Aug 2023 16:05:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232517AbjHMQFZ (ORCPT ); Sun, 13 Aug 2023 12:05:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231639AbjHMQE4 (ORCPT ); Sun, 13 Aug 2023 12:04:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC6031BF7; Sun, 13 Aug 2023 09:04:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CA6FF6369A; Sun, 13 Aug 2023 16:03:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA4BDC433C8; Sun, 13 Aug 2023 16:03:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691942628; bh=Ktz6GUFjtE/wS7SH9QxNxGF9v19Hltjlw0vZGd0JUXU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IeP2nmToSI8JU9b3XDA6hDxXRUBXidJQp9ko4oH90QSf8OtjWkrgIa4huZ4r05G4Z UVgHm6vl4KOsFcesI0KKnOpK+KebRWvMJS8ctPLMi4Mn1tlGmcjF/tSpZ/tmV4Q47z 1G+31ynf6Pl3a18xfzReR22a6DlAuvrMVssj/N/OJNMfmcveco7Rd+xY/wGd2hVG86 kFeYn6qVzh19uhy4oZD123BfgTnfPMMeKVaWesU5W8civLsgwpTgIQdHZoyUnEhsgm aCzvXGCinH3mebBdpxT06mBL7Bm+wpEq/VxLj4yKtZ5AlJPGyqzdszaRU14+jP6e7u Kot1/2R4+ynKg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Minjie Du , Viresh Kumar , Sergey Shtylyov , Damien Le Moal , Sasha Levin , vireshk@kernel.org, linux-ide@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 41/47] ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer() Date: Sun, 13 Aug 2023 11:59:36 -0400 Message-Id: <20230813160006.1073695-41-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230813160006.1073695-1-sashal@kernel.org> References: <20230813160006.1073695-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.45 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Minjie Du [ Upstream commit 4139f992c49356391fb086c0c8ce51f66c26d623 ] It is possible for dma_request_chan() to return EPROBE_DEFER, which means acdev->host->dev is not ready yet. At this point dev_err() will have no output. Use dev_err_probe() instead. Signed-off-by: Minjie Du Acked-by: Viresh Kumar Reviewed-by: Sergey Shtylyov Signed-off-by: Damien Le Moal Signed-off-by: Sasha Levin --- drivers/ata/pata_arasan_cf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c index e89617ed9175b..46588fc829432 100644 --- a/drivers/ata/pata_arasan_cf.c +++ b/drivers/ata/pata_arasan_cf.c @@ -529,7 +529,8 @@ static void data_xfer(struct work_struct *work) /* dma_request_channel may sleep, so calling from process context */ acdev->dma_chan = dma_request_chan(acdev->host->dev, "data"); if (IS_ERR(acdev->dma_chan)) { - dev_err(acdev->host->dev, "Unable to get dma_chan\n"); + dev_err_probe(acdev->host->dev, PTR_ERR(acdev->dma_chan), + "Unable to get dma_chan\n"); acdev->dma_chan = NULL; goto chan_request_fail; } -- 2.40.1