From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 828B7C41513 for ; Mon, 14 Aug 2023 09:25:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235741AbjHNJZe (ORCPT ); Mon, 14 Aug 2023 05:25:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235912AbjHNJZI (ORCPT ); Mon, 14 Aug 2023 05:25:08 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7EFDB18F; Mon, 14 Aug 2023 02:25:07 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6D4322F4; Mon, 14 Aug 2023 02:25:49 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A58663F6C4; Mon, 14 Aug 2023 02:25:05 -0700 (PDT) Date: Mon, 14 Aug 2023 10:25:03 +0100 From: Sudeep Holla To: Sibi Sankar Cc: cristian.marussi@arm.com, lukasz.luba@arm.com, Sudeep Holla , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, quic_rjendra@quicinc.com, srinivas.kandagatla@linaro.org, Chandra Sekhar Lingutla Subject: Re: [PATCH] firmware: arm_scmi: Fixup perf microwatt support Message-ID: <20230814092503.xdzafmqu5h3shrlz@bogus> References: <20230811204818.30928-1-quic_sibis@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230811204818.30928-1-quic_sibis@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 12, 2023 at 02:18:18AM +0530, Sibi Sankar wrote: > The perf power scale value would currently be reported as bogowatts if the > platform firmware supports microwatt power scale and meets the perf major > version requirements. Fix this by populating version information in the > driver private data before the call to protocol attributes is made. > > CC: Chandra Sekhar Lingutla > Fixes: 3630cd8130ce ("firmware: arm_scmi: Add SCMI v3.1 perf power-cost in microwatts") > Signed-off-by: Sibi Sankar > --- > drivers/firmware/arm_scmi/perf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c > index c0cd556fbaae..30dedd6ebfde 100644 > --- a/drivers/firmware/arm_scmi/perf.c > +++ b/drivers/firmware/arm_scmi/perf.c > @@ -1080,6 +1080,8 @@ static int scmi_perf_protocol_init(const struct scmi_protocol_handle *ph) Please rebase any patch when posting upstream on upstream kernel tree. This definitely looks like some downstream tree. I will adjust and apply this time. This file never crossed 1000 line and this patch indicates otherwise, so I am sure Qcom has some downstream changes in this file now. -- Regards, Sudeep