From: Hsin-Yi Wang <hsinyi@chromium.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Bjorn Andersson <andersson@kernel.org>
Cc: Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <michael@walle.cc>,
"Miquel Raynal )" <miquel.raynal@bootlin.com>,
"Richard Weinberger )" <richard@nod.at>,
"Vignesh Raghavendra )" <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
cros-qcom-dts-watchers@chromium.org,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: [PATCH 2/4] mtd: spi-nor: sfdp: read disable-quad-mode property
Date: Tue, 15 Aug 2023 23:31:53 +0800 [thread overview]
Message-ID: <20230815154412.713846-3-hsinyi@chromium.org> (raw)
In-Reply-To: <20230815154412.713846-1-hsinyi@chromium.org>
Some flash devices, eg. gd25lq64c, enable quad mode by default after
spi_nor_parse_bfpt(). However, the systems using these flash devices may
required the quad mode to be turned off to use write protection or to
avoid a potential short issue[1].
Add a disable-quad-mode property in devicetree that system can use it to
override the quad mode status parsed from BFPT.
[1]https://www.elm-tech.com/ja/products/spi-flash-memory/gd25lq64/gd25lq64.pdf
page 13
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/mtd/spi-nor/core.c | 5 +++++
drivers/mtd/spi-nor/core.h | 1 +
drivers/mtd/spi-nor/debugfs.c | 1 +
3 files changed, 7 insertions(+)
diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
index 614960c7d22cc..dcf4ff46c37ae 100644
--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -2847,6 +2847,11 @@ static void spi_nor_init_flags(struct spi_nor *nor)
if (of_property_read_bool(np, "no-wp"))
nor->flags |= SNOR_F_NO_WP;
+ if (of_property_read_bool(np, "disable-quad-mode")) {
+ nor->flags |= SNOR_F_DISABLE_QUAD;
+ nor->params->quad_enable = NULL;
+ }
+
if (flags & SPI_NOR_SWP_IS_VOLATILE)
nor->flags |= SNOR_F_SWP_IS_VOLATILE;
diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h
index 9217379b9cfef..b06bd97668f3a 100644
--- a/drivers/mtd/spi-nor/core.h
+++ b/drivers/mtd/spi-nor/core.h
@@ -133,6 +133,7 @@ enum spi_nor_option_flags {
SNOR_F_RWW = BIT(14),
SNOR_F_ECC = BIT(15),
SNOR_F_NO_WP = BIT(16),
+ SNOR_F_DISABLE_QUAD = BIT(17),
};
struct spi_nor_read_command {
diff --git a/drivers/mtd/spi-nor/debugfs.c b/drivers/mtd/spi-nor/debugfs.c
index 6e163cb5b478c..c17451ae0931a 100644
--- a/drivers/mtd/spi-nor/debugfs.c
+++ b/drivers/mtd/spi-nor/debugfs.c
@@ -28,6 +28,7 @@ static const char *const snor_f_names[] = {
SNOR_F_NAME(RWW),
SNOR_F_NAME(ECC),
SNOR_F_NAME(NO_WP),
+ SNOR_F_NAME(DISABLE_QUAD),
};
#undef SNOR_F_NAME
--
2.41.0.694.ge786442a9b-goog
next prev parent reply other threads:[~2023-08-15 15:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 15:31 [PATCH 0/4] Add a property to override the quad mode Hsin-Yi Wang
2023-08-15 15:31 ` [PATCH 1/4] dt-bindings: mtd: jedec,spi-nor: Add disable-quad-mode property Hsin-Yi Wang
2023-08-15 15:31 ` Hsin-Yi Wang [this message]
2023-08-15 15:31 ` [PATCH 3/4] arm64: dts: mediatek: mt8183: disable quad mode for spi nor Hsin-Yi Wang
2023-08-16 11:17 ` Eugen Hristev
2023-08-15 15:31 ` [PATCH 4/4] arm64: dts: qcom: sc7180: " Hsin-Yi Wang
2023-08-15 19:32 ` Doug Anderson
2023-08-15 15:59 ` [PATCH 0/4] Add a property to override the quad mode Michael Walle
2023-08-15 17:21 ` Hsin-Yi Wang
2023-08-15 19:19 ` Krzysztof Kozlowski
2023-08-16 10:48 ` Hsin-Yi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230815154412.713846-3-hsinyi@chromium.org \
--to=hsinyi@chromium.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®