mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "André Almeida" <andrealmeid@igalia.com>
To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: kernel-dev@igalia.com, alexander.deucher@amd.com,
	christian.koenig@amd.com, pierre-eric.pelloux-prayer@amd.com,
	"'Marek Olšák'" <maraeo@gmail.com>,
	"Samuel Pitoiset" <samuel.pitoiset@gmail.com>,
	"Bas Nieuwenhuizen" <bas@basnieuwenhuizen.nl>,
	"Timur Kristóf" <timur.kristof@gmail.com>,
	"André Almeida" <andrealmeid@igalia.com>
Subject: [PATCH v4 1/4] drm/amdgpu: Allocate coredump memory in a nonblocking way
Date: Tue, 15 Aug 2023 16:50:57 -0300	[thread overview]
Message-ID: <20230815195100.294458-2-andrealmeid@igalia.com> (raw)
In-Reply-To: <20230815195100.294458-1-andrealmeid@igalia.com>

During a GPU reset, a normal memory reclaim could block to reclaim
memory. Giving that coredump is a best effort mechanism, it shouldn't
disturb the reset path. Change its memory allocation flag to a
nonblocking one.

Signed-off-by: André Almeida <andrealmeid@igalia.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index aa171db68639..bf4781551f88 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -4847,7 +4847,7 @@ static void amdgpu_reset_capture_coredumpm(struct amdgpu_device *adev)
 	struct drm_device *dev = adev_to_drm(adev);
 
 	ktime_get_ts64(&adev->reset_time);
-	dev_coredumpm(dev->dev, THIS_MODULE, adev, 0, GFP_KERNEL,
+	dev_coredumpm(dev->dev, THIS_MODULE, adev, 0, GFP_NOWAIT,
 		      amdgpu_devcoredump_read, amdgpu_devcoredump_free);
 }
 #endif
-- 
2.41.0


  reply	other threads:[~2023-08-15 19:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-15 19:50 [PATCH v4 0/4] drm/amdgpu: Rework coredump memory allocation André Almeida
2023-08-15 19:50 ` André Almeida [this message]
2023-08-15 19:50 ` [PATCH v4 2/4] drm/amdgpu: Rework coredump to use memory dynamically André Almeida
2023-08-16  9:48   ` Christian König
2023-08-16 10:11     ` Shashank Sharma
2023-08-17  6:41   ` Shashank Sharma
2023-08-17 13:45     ` André Almeida
2023-08-17 15:04       ` Shashank Sharma
2023-08-17 15:17         ` André Almeida
2023-08-17 15:26           ` Shashank Sharma
2023-08-17 15:38             ` André Almeida
2023-08-17 15:42               ` Shashank Sharma
2023-08-15 19:50 ` [PATCH v4 3/4] drm/amdgpu: Move coredump code to amdgpu_reset file André Almeida
2023-08-16  9:52   ` Christian König
2023-08-15 19:51 ` [PATCH v4 4/4] drm/amdgpu: Create version number for coredumps André Almeida
2023-08-16  9:50   ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230815195100.294458-2-andrealmeid@igalia.com \
    --to=andrealmeid@igalia.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bas@basnieuwenhuizen.nl \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-dev@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maraeo@gmail.com \
    --cc=pierre-eric.pelloux-prayer@amd.com \
    --cc=samuel.pitoiset@gmail.com \
    --cc=timur.kristof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®