From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2DBFC001B0 for ; Tue, 15 Aug 2023 23:53:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240727AbjHOXwp (ORCPT ); Tue, 15 Aug 2023 19:52:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232960AbjHOXwU (ORCPT ); Tue, 15 Aug 2023 19:52:20 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35B96EE for ; Tue, 15 Aug 2023 16:52:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HfCZ9brg0iyE5Q8lglqtZyQbu0Jpru3LAR5+PlvOWsM=; b=ecUAP1yLvKcjKgpVVpJcK1ujbX D0hBUB1OOsgX4VZ1b5hvrP1iC9huVAECuD47toguaGbisMGRKhBwDbb3uwyuHeuwS/kP4UHE2cleV rnI5VL97JgrDeV/OJ/L5FpS1ozb6iC1jOFWBU+gTED4SQCo+bot81nBxtgiqYoY3Jp2aFqqZUH8vu eQwVHDCoozMMxEH7hVHCe/WICFnemnmC3AwI/OxbFWI4z/FKxIagcB0zR3j1qWqh5rbz8N5K2b7RE shSr/6yWpfUWk6YyaVGyG71dySnx0o0ZWzsFs3fuofOvVCp8cONk96/an12uw5bSgg2YMHr9oOSo8 RsIASD1A==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qW3pS-00CD4s-12; Tue, 15 Aug 2023 23:52:07 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id AC3B8300388; Wed, 16 Aug 2023 01:52:01 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8B2022C865681; Wed, 16 Aug 2023 01:52:01 +0200 (CEST) Date: Wed, 16 Aug 2023 01:52:01 +0200 From: Peter Zijlstra To: Mike Galbraith Cc: Chen Yu , kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, x86@kernel.org, Ingo Molnar Subject: Re: [tip:sched/eevdf] [sched/fair] e0c2ff903c: phoronix-test-suite.blogbench.Write.final_score -34.8% regression Message-ID: <20230815235201.GH971582@hirez.programming.kicks-ass.net> References: <202308101628.7af4631a-oliver.sang@intel.com> <20230814132935.GK776869@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 14, 2023 at 08:32:55PM +0200, Mike Galbraith wrote: > I don't have that phoronix thingy, but the above didn't seem to do > anything for hackbench here. Yeah, looking at it this is because the lag and the request/slice are on the same order of things. More thinking required, but perhaps not at 2am. > I whack eevdf with the stick below to dampen its scheduling enthusiasm > a little, and it did help the hackbench deficit some. I'm thinking there's an argument to be had the current WAKEUP_PREEMPTION knob is at the wrong place and should be more or less where you put the triddle at.