From: Peter Zijlstra <peterz@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
dan.j.williams@intel.com, linux-kernel@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: cleanup: Make no_free_ptr() __must_check
Date: Wed, 16 Aug 2023 11:17:07 +0200 [thread overview]
Message-ID: <20230816091707.GA980931@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAHk-=wiOXePAqytCk6JuiP6MeePL6ksDYptE54hmztiGLYihjA@mail.gmail.com>
On Wed, Aug 16, 2023 at 08:00:17AM +0000, Linus Torvalds wrote:
> So I think it needs to be something like
>
> #define __get_and_free_ptr(p) \
> ({ __auto_type __ptr = &(p); \
> __auto_type __val = *__ptr; \
> *__ptr = NULL; __val; })
>
> static inline __must_check
> const volatile void * __must_check_fn(const volatile void *val)
> { return val; }
>
> #define no_free_ptr(p) \
> ((typeof(p)) __must_check_fn(__get_and_free_ptr(p)))
>
> the above is entirely untested. Of course.
That works and is *much* saner than the horrible thing I did.
prev parent reply other threads:[~2023-08-16 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 10:52 Peter Zijlstra
2023-08-15 11:28 ` Rasmus Villemoes
2023-08-15 13:53 ` Peter Zijlstra
2023-08-15 15:16 ` David Laight
2023-08-16 7:23 ` Rasmus Villemoes
2023-08-16 8:00 ` Linus Torvalds
2023-08-16 8:58 ` Rasmus Villemoes
2023-08-16 9:17 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816091707.GA980931@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=ndesaulniers@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®