From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0289DC001E0 for ; Wed, 16 Aug 2023 12:21:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245068AbjHPMU3 (ORCPT ); Wed, 16 Aug 2023 08:20:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245074AbjHPMUN (ORCPT ); Wed, 16 Aug 2023 08:20:13 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 243F2109 for ; Wed, 16 Aug 2023 05:20:12 -0700 (PDT) Date: Wed, 16 Aug 2023 14:20:07 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1692188410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MaUwkyTxNitYNx61TmEE8oVCLZ3GY9p7YUKFRU3g2qc=; b=KuCcd25Yq+ISwHIIW17Pd/ZAsu3HnhhQgsaF2PN9qQxzh2YuHvz2dyKPWYrK4lkQoH31Or z5xTnAJWWtt4UQfmYjKOoxTNBFPqXQNSELKrv5u3it5A5Ol7rHrsFEAkUAoCT6Ck6fWhH1 t8/keBHpD6epC9nkIBfmMW9FXMd+B/02Unv2y0Qp9DADDO4Vtl5trzYdWlbG6Qmu+sL5T5 k5jPk+ZlX0//15U2VCWdN7RdbK7XL6ClyV0FpJTcejARGKgsNoH6LmjzNo5Y26EBq8WlyP uERB0nG4+iHAPr/5f4WQdvWEh2vKlQ3tVIMpgxAwD6GVI7XtCRC6RomkH7CVDA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1692188410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MaUwkyTxNitYNx61TmEE8oVCLZ3GY9p7YUKFRU3g2qc=; b=d22kaDJLiixr810KQ+8/JI3xOV621kQkZWV/260VxR1VYjfmGkS2wNszadau8pIvXPWK2N ALtuRv7Y7+VIqrBA== From: Sebastian Andrzej Siewior To: Phil Auld Cc: Peter Zijlstra , tglx@linutronix.de, linux-kernel@vger.kernel.org, bsegall@google.com, boqun.feng@gmail.com, swood@redhat.com, bristot@redhat.com, dietmar.eggemann@arm.com, mingo@redhat.com, jstultz@google.com, juri.lelli@redhat.com, mgorman@suse.de, rostedt@goodmis.org, vschneid@redhat.com, vincent.guittot@linaro.org, longman@redhat.com, will@kernel.org Subject: Re: [PATCH 3/6] sched: Extract __schedule_loop() Message-ID: <20230816122007.W7OJW3Fx@linutronix.de> References: <20230815110121.117752409@infradead.org> <20230815111430.288063671@infradead.org> <20230815223301.GC602899@lorien.usersys.redhat.com> <20230816100154.k6cmHUUp@linutronix.de> <20230816113945.GA639355@lorien.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230816113945.GA639355@lorien.usersys.redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-08-16 07:39:45 [-0400], Phil Auld wrote: > I do. Admittedly I'm not an expert in how the wchan unwinding works but > we have a slightly older version of this patch in our kernel (schedule_loop > not __schedule_loop). When I added __sched it fixed it. Maybe there > is something else but that seemed pretty obvious. > > > /* Attach to any functions which should be ignored in wchan output. */ > #define __sched __section(".sched.text") > > I can't explain why you are not seeing it. as peterz pointed out, it is marked __always_inline so the compiler shouldn't make a separate function out of it. Could you check with _this_ series? The schedule_loop variant is in RT and does not have this inline thingy. So it would be good if the issue you report actually exists in the series that has been posted. > Cheers, > Phil Sebastian