From: Guenter Roeck <linux@roeck-us.net>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Benson Leung <bleung@chromium.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Thomas Gleixner <tglx@linutronix.de>,
John Stultz <jstultz@google.com>, Stephen Boyd <sboyd@kernel.org>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
Brian Norris <briannorris@chromium.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH 6/7] rtc: ds1305: Report maximum alarm limit to rtc core
Date: Wed, 16 Aug 2023 06:39:35 -0700 [thread overview]
Message-ID: <20230816133936.2150294-7-linux@roeck-us.net> (raw)
In-Reply-To: <20230816133936.2150294-1-linux@roeck-us.net>
DS1305 only supports alarms up to 24 hours in the future.
Report the limit to the RTC core.
If the alarm is too large when trying to set an alarm, return -ERANGE
instead of -EDOM to align with error codes returned by other rtc drivers.
Cc: Brian Norris <briannorris@chromium.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/rtc/rtc-ds1305.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-ds1305.c b/drivers/rtc/rtc-ds1305.c
index ed9360486953..1d9bbf4e06cb 100644
--- a/drivers/rtc/rtc-ds1305.c
+++ b/drivers/rtc/rtc-ds1305.c
@@ -337,7 +337,7 @@ static int ds1305_set_alarm(struct device *dev, struct rtc_wkalrm *alm)
if (later <= now)
return -EINVAL;
if ((later - now) > 24 * 60 * 60)
- return -EDOM;
+ return -ERANGE;
/* disable alarm if needed */
if (ds1305->ctrl[0] & DS1305_AEI0) {
@@ -691,6 +691,7 @@ static int ds1305_probe(struct spi_device *spi)
ds1305->rtc->ops = &ds1305_ops;
ds1305->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000;
ds1305->rtc->range_max = RTC_TIMESTAMP_END_2099;
+ ds1305->rtc->range_max_offset = 24 * 60 * 60;
ds1305_nvmem_cfg.priv = ds1305;
status = devm_rtc_register_device(ds1305->rtc);
--
2.39.2
next prev parent reply other threads:[~2023-08-16 13:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 13:39 [PATCH 0/7] rtc: Add support for limited alarm timer offsets Guenter Roeck
2023-08-16 13:39 ` [PATCH 1/7] " Guenter Roeck
2023-08-16 14:57 ` Alexandre Belloni
2023-08-16 15:24 ` Guenter Roeck
2023-08-16 16:19 ` Alexandre Belloni
2023-08-16 19:12 ` Guenter Roeck
2023-08-16 13:39 ` [PATCH 2/7] rtc: alarmtimer: Use maximum alarm time offset Guenter Roeck
2023-08-16 13:39 ` [PATCH 3/7] rtc: cros-ec: Detect and report supported alarm window size Guenter Roeck
2023-08-16 13:39 ` [PATCH 4/7] rtc: cmos: Report supported alarm limit to rtc infrastructure Guenter Roeck
2023-08-16 13:39 ` [PATCH 5/7] rtc: tps6586x: Report maximum alarm limit to rtc core Guenter Roeck
2023-08-16 13:39 ` Guenter Roeck [this message]
2023-08-16 13:39 ` [PATCH 7/7] rtc: rzn1: " Guenter Roeck
2023-08-17 8:03 ` Miquel Raynal
2023-08-17 13:43 ` Guenter Roeck
2023-08-16 15:03 ` [PATCH 0/7] rtc: Add support for limited alarm timer offsets Alexandre Belloni
2023-08-16 15:50 ` Guenter Roeck
2023-08-16 16:14 ` Alexandre Belloni
2023-08-16 19:12 ` Guenter Roeck
2023-08-17 19:51 ` Alexandre Belloni
2023-08-17 22:36 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816133936.2150294-7-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bleung@chromium.org \
--cc=briannorris@chromium.org \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®