mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: linux-erofs@lists.ozlabs.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Gao Xiang <hsiangkao@linux.alibaba.com>
Subject: [PATCH 6/8] erofs: get rid of fe->backmost for cache decompression
Date: Thu, 17 Aug 2023 16:28:11 +0800	[thread overview]
Message-ID: <20230817082813.81180-6-hsiangkao@linux.alibaba.com> (raw)
In-Reply-To: <20230817082813.81180-1-hsiangkao@linux.alibaba.com>

EROFS_MAP_FULL_MAPPED is more accurate to decide if caching the last
incomplete pcluster for later read or not.

Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
 fs/erofs/zdata.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
index 4009283944ca..c28945532a02 100644
--- a/fs/erofs/zdata.c
+++ b/fs/erofs/zdata.c
@@ -528,8 +528,6 @@ struct z_erofs_decompress_frontend {
 	z_erofs_next_pcluster_t owned_head;
 	enum z_erofs_pclustermode mode;
 
-	/* used for applying cache strategy on the fly */
-	bool backmost;
 	erofs_off_t headoffset;
 
 	/* a pointer used to pick up inplace I/O pages */
@@ -538,7 +536,7 @@ struct z_erofs_decompress_frontend {
 
 #define DECOMPRESS_FRONTEND_INIT(__i) { \
 	.inode = __i, .owned_head = Z_EROFS_PCLUSTER_TAIL, \
-	.mode = Z_EROFS_PCLUSTER_FOLLOWED, .backmost = true }
+	.mode = Z_EROFS_PCLUSTER_FOLLOWED }
 
 static bool z_erofs_should_alloc_cache(struct z_erofs_decompress_frontend *fe)
 {
@@ -547,7 +545,7 @@ static bool z_erofs_should_alloc_cache(struct z_erofs_decompress_frontend *fe)
 	if (cachestrategy <= EROFS_ZIP_CACHE_DISABLED)
 		return false;
 
-	if (fe->backmost)
+	if (!(fe->map.m_flags & EROFS_MAP_FULL_MAPPED))
 		return true;
 
 	if (cachestrategy >= EROFS_ZIP_CACHE_READAROUND &&
@@ -939,7 +937,6 @@ static void z_erofs_pcluster_end(struct z_erofs_decompress_frontend *fe)
 		erofs_workgroup_put(&pcl->obj);
 
 	fe->pcl = NULL;
-	fe->backmost = false;
 }
 
 static int z_erofs_read_fragment(struct super_block *sb, struct page *page,
-- 
2.24.4


  parent reply	other threads:[~2023-08-17  8:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17  8:28 [PATCH 1/8] erofs: simplify z_erofs_read_fragment() Gao Xiang
2023-08-17  8:28 ` [PATCH 2/8] erofs: avoid obsolete {collector,collection} terms Gao Xiang
2023-08-18  2:25   ` Yue Hu
2023-08-23 14:58   ` Chao Yu
2023-08-17  8:28 ` [PATCH 3/8] erofs: move preparation logic into z_erofs_pcluster_begin() Gao Xiang
2023-08-18  2:42   ` Yue Hu
2023-08-23 15:05   ` Chao Yu
2023-08-23 15:22     ` Gao Xiang
2023-08-17  8:28 ` [PATCH 4/8] erofs: tidy up z_erofs_do_read_page() Gao Xiang
2023-08-18  3:12   ` Yue Hu
2023-08-23 15:09   ` Chao Yu
2023-08-17  8:28 ` [PATCH 5/8] erofs: drop z_erofs_page_mark_eio() Gao Xiang
2023-08-18  3:20   ` Yue Hu
2023-08-23 15:19   ` Chao Yu
2023-08-17  8:28 ` Gao Xiang [this message]
2023-08-18  5:51   ` [PATCH 6/8] erofs: get rid of fe->backmost for cache decompression Yue Hu
2023-08-18  7:48     ` Gao Xiang
2023-08-18  8:02       ` Yue Hu
2023-08-23 15:19   ` Chao Yu
2023-08-17  8:28 ` [PATCH 7/8] erofs: adapt folios for z_erofs_readahead() Gao Xiang
2023-08-23 15:22   ` Chao Yu
2023-08-17  8:28 ` [PATCH 8/8] erofs: adapt folios for z_erofs_read_folio() Gao Xiang
2023-08-17  8:39   ` [PATCH v2 " Gao Xiang
2023-08-23 15:23   ` [PATCH " Chao Yu
2023-08-18  2:18 ` [PATCH 1/8] erofs: simplify z_erofs_read_fragment() Yue Hu
2023-08-23 14:56 ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230817082813.81180-6-hsiangkao@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®