From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA71C2FC14 for ; Thu, 17 Aug 2023 08:44:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349041AbjHQInr (ORCPT ); Thu, 17 Aug 2023 04:43:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349051AbjHQInS (ORCPT ); Thu, 17 Aug 2023 04:43:18 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF0361FC3 for ; Thu, 17 Aug 2023 01:43:16 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-565e6a9ccedso1383678a12.1 for ; Thu, 17 Aug 2023 01:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692261796; x=1692866596; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=q2L4C5R28cbryggTkgsTbJhOs95hAoOhjBRL8672G4w=; b=w48wRkJFgSgs14mGvW8yL9VkRkVfhujtSK5SMpUTWjNIRTy4j3dqLigip+/7P/yqxl WAos9+gjFyT/LWGz0ZFfpGKJZBg4c6atVw8+J1vAxiSPInA2eRFw2nwTLVE5EQzXRBDt mF+8zvQp/dS1vqYRlIRfzx2NX99kIiwe4ZAaV8nSwUA6PzhedfBo6aEg6AOii1v6SN6/ a/cYPh2RBcwLRuLteXsUKHjCopAqQ/yQy9BZFAGhBNAU95POH70qyJBgR/Gu/7D0fl3H GNNNgAZ7ETMyc63vxwFlo1Snn4h6bJ0JFZLaXHGuRWH7vpdky/EiNSSAy88PWanFaHsS itkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692261796; x=1692866596; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q2L4C5R28cbryggTkgsTbJhOs95hAoOhjBRL8672G4w=; b=cETCxFzoD+zDvZxw8UVnNS/1Kv4i6BN7G0Ww47lZJwHNTWgBiFrCi3crj64Kd+TFY5 4QCyS7d8YqRLTkOH98LT6OfZIIGYb29l3y7IlKy0zljNpkFva9aumLkhLGWzSIrHUJMO 6R4YjOUFLjEfe/LxmccUsXpDuT69yJQZmMlEQSKWnt5S8oC+28pDVr/N04cJCqBzSIsq niVyW5zBy5ADiuTZsMrvcaMOHAiC4EtARDkz6j8R2+EA5OoYyLmaJDqFrQfRUIYnd2Qw A7QEAbGLVAObMQk04A3/yECmGQgbHI8HtyZwwBn9gF3DJ6ZlPI7hPQDTeroMOi+KFYRi x+NQ== X-Gm-Message-State: AOJu0YyB4/P/EihB8hYRsP84yULyx23qWyPHAdHxsCy/gvzwGtWUpA8y bg9yog5CGxOSlk0Sc1w8T/MaJZtCWzRnE/uYNeU= X-Google-Smtp-Source: AGHT+IGQrst5AZOFbEPCDmMYUExv2C/YC6Cai1Zz5cEBkHsY3pX7eqss6vxelOypQNoP9bmFVWQC1A== X-Received: by 2002:a17:90a:c7c4:b0:268:5575:93d9 with SMTP id gf4-20020a17090ac7c400b00268557593d9mr3260325pjb.10.1692261796011; Thu, 17 Aug 2023 01:43:16 -0700 (PDT) Received: from localhost ([122.172.87.195]) by smtp.gmail.com with ESMTPSA id b19-20020a17090ae39300b002682523653asm1057274pjz.49.2023.08.17.01.43.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 01:43:15 -0700 (PDT) Date: Thu, 17 Aug 2023 14:13:13 +0530 From: Viresh Kumar To: Liao Chang Cc: rafael@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] cpufreq: cppc: Set fie_disabled to FIE_DISABLED if fails to create kworker_fie Message-ID: <20230817084313.2tffmexdzvmpyend@vireshk-i7> References: <20230817074756.883380-1-liaochang1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230817074756.883380-1-liaochang1@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17-08-23, 07:47, Liao Chang wrote: > The function cppc_freq_invariance_init() may failed to create > kworker_fie, make it more robust by setting fie_disabled to FIE_DISBALED > to prevent an invalid pointer dereference in kthread_destroy_worker(), > which called from cppc_freq_invariance_exit(). > > v3: > Simplify cleanup code when invariance initialization fails. > > v2: > Set fie_disabled to FIE_DISABLED when invariance initialization fails. > > Link: https://lore.kernel.org/all/20230816034630.a4hvsj373q6aslk3@vireshk-i7/ > > Signed-off-by: Liao Chang > --- > drivers/cpufreq/cppc_cpufreq.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c > index 022e3555407c..4d501f0bf55d 100644 > --- a/drivers/cpufreq/cppc_cpufreq.c > +++ b/drivers/cpufreq/cppc_cpufreq.c > @@ -249,15 +249,19 @@ static void __init cppc_freq_invariance_init(void) > return; > > kworker_fie = kthread_create_worker(0, "cppc_fie"); > - if (IS_ERR(kworker_fie)) > + if (IS_ERR(kworker_fie)) { > + pr_warn("%s: failed to create kworker_fie: %ld\n", __func__, > + PTR_ERR(kworker_fie)); > + fie_disabled = FIE_DISABLED; > return; > + } > > ret = sched_setattr_nocheck(kworker_fie->task, &attr); > if (ret) { > pr_warn("%s: failed to set SCHED_DEADLINE: %d\n", __func__, > ret); > kthread_destroy_worker(kworker_fie); > - return; > + fie_disabled = FIE_DISABLED; > } > } > > @@ -267,7 +271,6 @@ static void cppc_freq_invariance_exit(void) > return; > > kthread_destroy_worker(kworker_fie); > - kworker_fie = NULL; > } > > #else Applied. Thanks. -- viresh