From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EEFBC41513 for ; Thu, 17 Aug 2023 08:57:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349153AbjHQI4w (ORCPT ); Thu, 17 Aug 2023 04:56:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349151AbjHQI43 (ORCPT ); Thu, 17 Aug 2023 04:56:29 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0F4D2724 for ; Thu, 17 Aug 2023 01:56:27 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1bdc8081147so4854515ad.1 for ; Thu, 17 Aug 2023 01:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692262587; x=1692867387; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ptze6wxZV514oS0u92VIY9O4Y7H/mluSZc2DMC6gWxY=; b=FkGU/hYU22VtQfcjslmCB7Eku6oqlepKKvYflypvWxwE5eJurcUMGULy6KJ4NsCqPY TdWSGeDmWVbZftbl7rc9eU5nta2jIa/Xf1nukzVpcLk6macZBlbFHlvrNWMKc35mE+bc y+IBiXwDawJN0XHqZQ7rlIjM69uHAMtoREtvYzvQfiBiCDxuIk4WF57HJOLMQx6gUZ2V 9IeVSD8jE9VfEBD/2J9VKZeC26my7sQM8+OisNt4LFVPHEQLZYeA0g75586NUbLaTDsH 45lP7QpKCAfYeUhfzLhl8uuXyXCbcBG8nHQ7PIE042Stn8nhF5xSkm/aI8LL3aB/35LN zT9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692262587; x=1692867387; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ptze6wxZV514oS0u92VIY9O4Y7H/mluSZc2DMC6gWxY=; b=HznuqZ6cGRNSgn0DCEj1IdfnmSNxFF4Mtc/u5z9U6fBHbr4f2pGMRevka0p/CzabMD W+sl7NQ5M8GGxV/FJApLmHH2yGvttoPa9ODoEXoUGJN+PCqwLlSzhcwE00rQqZDwaDmE yV5lQdZndohwSXxKNAy6HRIovdtmyjk1WbE9e4mW/HpF2FT7HjZTQ8xUFY5x/TAXSYq0 77kwXzQs+K7g2pcuRjqtDwq16vCJadwVCfOJe6HWABIDtgXfgWh10XiHXpZVvd+WUzNQ ZFlReHZLphhF5+HJC/sJI9hWf+Jrg7YrGqX9h8rY/IrrwHr9MZlVaY8aOODlKKuUGrp0 yfYw== X-Gm-Message-State: AOJu0YzrGtamUdtJ13GcU/U5zcvaxo9mK1NpvGjKu7423IinMfxgkw9I 1nDl6tMMzz+sZPcNUaRFecrYJg== X-Google-Smtp-Source: AGHT+IFYnONOUzUUhleUOayXtQmkupns0vXfS1SaXmi+vUdyLJtjr255SOUv8MF7357tYQr9D1ZTmA== X-Received: by 2002:a17:902:d48e:b0:1b8:a67f:1c15 with SMTP id c14-20020a170902d48e00b001b8a67f1c15mr2681591plg.25.1692262587137; Thu, 17 Aug 2023 01:56:27 -0700 (PDT) Received: from localhost ([122.172.87.195]) by smtp.gmail.com with ESMTPSA id jd2-20020a170903260200b001bdcafcf8d3sm10164168plb.69.2023.08.17.01.56.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 01:56:26 -0700 (PDT) Date: Thu, 17 Aug 2023 14:26:24 +0530 From: Viresh Kumar To: Liao Chang Cc: rafael@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] cpufreq: cppc: Set fie_disabled to FIE_DISABLED if fails to create kworker_fie Message-ID: <20230817085624.dfevjozfpmmxcldn@vireshk-i7> References: <20230817074756.883380-1-liaochang1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230817074756.883380-1-liaochang1@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17-08-23, 07:47, Liao Chang wrote: > The function cppc_freq_invariance_init() may failed to create > kworker_fie, make it more robust by setting fie_disabled to FIE_DISBALED > to prevent an invalid pointer dereference in kthread_destroy_worker(), > which called from cppc_freq_invariance_exit(). Btw, this version information present below should be added ... (see later) > v3: > Simplify cleanup code when invariance initialization fails. > > v2: > Set fie_disabled to FIE_DISABLED when invariance initialization fails. > > Link: https://lore.kernel.org/all/20230816034630.a4hvsj373q6aslk3@vireshk-i7/ > > Signed-off-by: Liao Chang > --- ... here after the "---" line, this way this not-so-useful information will not be committed while applying the patch. > drivers/cpufreq/cppc_cpufreq.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) -- viresh