drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:108: warning: Function parameter or member 'rcfw' not described in 'bnxt_re_is_fw_stalled'

[kernel test robot <lkp@intel.com>]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   16931859a6500d360b90aeacab3b505a3560a3ed
commit: f0c875ff6293965a30aaeb02a0d19b293e11bc2b RDMA/bnxt_re: use firmware provided max request timeout
date:   10 weeks ago
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230818/202308180600.oOnkIAQV-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230818/202308180600.oOnkIAQV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308180600.oOnkIAQV-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:73: warning: Function parameter or member 'opcode' not described in 'bnxt_qplib_map_rc'
>> drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:108: warning: Function parameter or member 'rcfw' not described in 'bnxt_re_is_fw_stalled'
>> drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:108: warning: Function parameter or member 'cookie' not described in 'bnxt_re_is_fw_stalled'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:108: warning: Function parameter or member 'opcode' not described in 'bnxt_re_is_fw_stalled'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:108: warning: Function parameter or member 'cbit' not described in 'bnxt_re_is_fw_stalled'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:140: warning: Function parameter or member 'rcfw' not described in '__wait_for_resp'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:140: warning: Function parameter or member 'cookie' not described in '__wait_for_resp'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:140: warning: Function parameter or member 'opcode' not described in '__wait_for_resp'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:188: warning: Function parameter or member 'rcfw' not described in '__block_for_resp'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:188: warning: Function parameter or member 'cookie' not described in '__block_for_resp'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:188: warning: Function parameter or member 'opcode' not described in '__block_for_resp'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:386: warning: Function parameter or member 'rcfw' not described in '__poll_for_resp'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:386: warning: Function parameter or member 'cookie' not described in '__poll_for_resp'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:386: warning: Function parameter or member 'opcode' not described in '__poll_for_resp'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:484: warning: Function parameter or member 'rcfw' not described in '__bnxt_qplib_rcfw_send_message'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:484: warning: Function parameter or member 'msg' not described in '__bnxt_qplib_rcfw_send_message'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:566: warning: Function parameter or member 'rcfw' not described in 'bnxt_qplib_rcfw_send_message'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:566: warning: Function parameter or member 'msg' not described in 'bnxt_qplib_rcfw_send_message'


vim +108 drivers/infiniband/hw/bnxt_re/qplib_rcfw.c

    55	
    56	/**
    57	 * bnxt_qplib_map_rc  -  map return type based on opcode
    58	 * @opcode    -  roce slow path opcode
    59	 *
    60	 * In some cases like firmware halt is detected, the driver is supposed to
    61	 * remap the error code of the timed out command.
    62	 *
    63	 * It is not safe to assume hardware is really inactive so certain opcodes
    64	 * like destroy qp etc are not safe to be returned success, but this function
    65	 * will be called when FW already reports a timeout. This would be possible
    66	 * only when FW crashes and resets. This will clear all the HW resources.
    67	 *
    68	 * Returns:
    69	 * 0 to communicate success to caller.
    70	 * Non zero error code to communicate failure to caller.
    71	 */
    72	static int bnxt_qplib_map_rc(u8 opcode)
  > 73	{
    74		switch (opcode) {
    75		case CMDQ_BASE_OPCODE_DESTROY_QP:
    76		case CMDQ_BASE_OPCODE_DESTROY_SRQ:
    77		case CMDQ_BASE_OPCODE_DESTROY_CQ:
    78		case CMDQ_BASE_OPCODE_DEALLOCATE_KEY:
    79		case CMDQ_BASE_OPCODE_DEREGISTER_MR:
    80		case CMDQ_BASE_OPCODE_DELETE_GID:
    81		case CMDQ_BASE_OPCODE_DESTROY_QP1:
    82		case CMDQ_BASE_OPCODE_DESTROY_AH:
    83		case CMDQ_BASE_OPCODE_DEINITIALIZE_FW:
    84		case CMDQ_BASE_OPCODE_MODIFY_ROCE_CC:
    85		case CMDQ_BASE_OPCODE_SET_LINK_AGGR_MODE:
    86			return 0;
    87		default:
    88			return -ETIMEDOUT;
    89		}
    90	}
    91	
    92	/**
    93	 * bnxt_re_is_fw_stalled   -	Check firmware health
    94	 * @rcfw      -   rcfw channel instance of rdev
    95	 * @cookie    -   cookie to track the command
    96	 * @opcode    -   rcfw submitted for given opcode
    97	 * @cbit      -   bitmap entry of cookie
    98	 *
    99	 * If firmware has not responded any rcfw command within
   100	 * rcfw->max_timeout, consider firmware as stalled.
   101	 *
   102	 * Returns:
   103	 * 0 if firmware is responding
   104	 * -ENODEV if firmware is not responding
   105	 */
   106	static int bnxt_re_is_fw_stalled(struct bnxt_qplib_rcfw *rcfw,
   107					 u16 cookie, u8 opcode, u16 cbit)
 > 108	{
   109		struct bnxt_qplib_cmdq_ctx *cmdq;
   110	
   111		cmdq = &rcfw->cmdq;
   112	
   113		if (time_after(jiffies, cmdq->last_seen +
   114			      (rcfw->max_timeout * HZ))) {
   115			dev_warn_ratelimited(&rcfw->pdev->dev,
   116					     "%s: FW STALL Detected. cmdq[%#x]=%#x waited (%d > %d) msec active %d ",
   117					     __func__, cookie, opcode,
   118					     jiffies_to_msecs(jiffies - cmdq->last_seen),
   119					     rcfw->max_timeout * 1000,
   120					     test_bit(cbit, cmdq->cmdq_bitmap));
   121			return -ENODEV;
   122		}
   123	
   124		return 0;
   125	}
   126	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki