From: Mario Limonciello <mario.limonciello@amd.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Bjorn Helgaas <helgaas@kernel.org>
Cc: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-acpi@vger.kernel.org>,
Iain Lane <iain@orangesquash.org.uk>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH v14.c 4/4] PCI: ACPI: Limit the Intel specific opt-in to D3 to 2024
Date: Fri, 18 Aug 2023 14:40:27 -0500 [thread overview]
Message-ID: <20230818194027.27559-5-mario.limonciello@amd.com> (raw)
In-Reply-To: <20230818194027.27559-1-mario.limonciello@amd.com>
Intel systems that need to have PCIe ports in D3 for low power idle
specify this by constraints on the ACPI PNP0D80 device. As this information
is queried by acpi_pci_bridge_d3(), limit the DMI BIOS year check to stop
at 2024. This will allow future systems to rely on the constraints check
and ACPI checks to set up policy like non-Intel systems do.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v13->v14:
* Use a variable instead
v12->v13:
* New patch
---
drivers/pci/pci.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index bfdad2eb36d13..c8787d898c377 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -3037,16 +3037,22 @@ bool pci_bridge_d3_possible(struct pci_dev *bridge)
return false;
/*
- * Allow Intel PCIe ports from 2015 onward to go into D3 to
+ * Allow Intel PCIe ports from 2015 to 2024 to go into D3 to
* achieve additional energy conservation on some platforms.
*
+ * Intel systems from 2025 onward that need this are expected
+ * to specify this in an LPS0 device constraint instead.
+ *
* This is only set for Intel PCIe ports as it causes problems
* on both AMD Rembrandt and Phoenix platforms where USB keyboards
* can not be used to wake the system from suspend.
*/
- if (bridge->vendor == PCI_VENDOR_ID_INTEL &&
- dmi_get_bios_year() >= 2015)
- return true;
+ if (bridge->vendor == PCI_VENDOR_ID_INTEL) {
+ int year = dmi_get_bios_year();
+
+ if (year >= 2015 && year <= 2024)
+ return true;
+ }
break;
}
--
2.34.1
next prev parent reply other threads:[~2023-08-18 19:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 19:40 [PATCH v14.c 0/4] Use LPS0 constraints to opt devices into D3 Mario Limonciello
2023-08-18 19:40 ` [PATCH v14.c 1/4] PCI: ACPI: Add helper functions for converting ACPI <-> PCI states Mario Limonciello
2023-08-21 18:35 ` Rafael J. Wysocki
2023-08-18 19:40 ` [PATCH v14.c 2/4] PCI: ACPI: Consider non-hotplug bridges for D3 in acpi_pci_bridge_d3() Mario Limonciello
2023-08-21 18:36 ` Rafael J. Wysocki
2023-08-18 19:40 ` [PATCH v14.c 3/4] PCI: ACPI: Use device constraints to opt devices into D3 support Mario Limonciello
2023-08-21 18:38 ` Rafael J. Wysocki
2023-08-18 19:40 ` Mario Limonciello [this message]
2023-08-21 18:46 ` [PATCH v14.c 4/4] PCI: ACPI: Limit the Intel specific opt-in to D3 to 2024 Rafael J. Wysocki
2023-08-21 19:18 ` Limonciello, Mario
2023-08-21 19:24 ` Rafael J. Wysocki
2023-08-21 19:26 ` Limonciello, Mario
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818194027.27559-5-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=iain@orangesquash.org.uk \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®