From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8205EE49A3 for ; Sat, 19 Aug 2023 01:49:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242686AbjHSBsz (ORCPT ); Fri, 18 Aug 2023 21:48:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242219AbjHSBse (ORCPT ); Fri, 18 Aug 2023 21:48:34 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18F163C38; Fri, 18 Aug 2023 18:48:33 -0700 (PDT) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37J1hP03010288; Sat, 19 Aug 2023 01:48:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=mcu2hatx8VdWJAJO8PKbmDkQUOSnUi0Rs+E/a0ePoLY=; b=hckyCZVNwTisIlsznvlppCO9Eql96rUmUX3qg/qQfP7K35OtuxnmB8UApf4X3TNaSnIG VE5/u0tpCNr4BmB1E+Axxhqsf9FfPMQ+FhSwlbSmQUJvV0Z8/uTAnLdclb66vW+3j2rj sBceBEq/xo7NN9EQSOmSRZdaicIEjE+Qat20+Cimnqp1rVq8VaeX+AJd/4NSf41RecOQ REzY+ZUfFODDOMjfV3l2pX/oN3nlwyPOdFs0DJN3WjVxJoacKyFCv4XjxoLUaeIr60st ALNZlWnootmY5vQKNoBddBCHGRJ8QGkTdaXTFXWmqIJMTdqpvOXnoEXh6KfR5xMewg7r UQ== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3sjk3tg2rb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 19 Aug 2023 01:48:16 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 37J1mFwY006390 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 19 Aug 2023 01:48:15 GMT Received: from quicinc.com (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Fri, 18 Aug 2023 18:48:15 -0700 Date: Fri, 18 Aug 2023 18:48:13 -0700 From: Guru Das Srinagesh To: Neil Armstrong CC: Guru Das Srinagesh , Krzysztof Kozlowski , Masahiro Yamada , Nick Desaulniers , Andrew Morton , Nicolas Schier , Kees Cook , Bjorn Andersson , , , Will Deacon , Greg Kroah-Hartman , , , , , , , Subject: Re: [PATCH v2 0/1] Add add-maintainer.py script Message-ID: <20230819014813.GB22393@quicinc.com> Mail-Followup-To: Neil Armstrong , Krzysztof Kozlowski , Masahiro Yamada , Nick Desaulniers , Andrew Morton , Nicolas Schier , Kees Cook , Bjorn Andersson , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Will Deacon , Greg Kroah-Hartman , quic_pkondeti@quicinc.com, u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org References: <20230810185526.GC31860@quicinc.com> <4d94d0fd-72d4-0196-3a30-3e1efb9f5aca@linaro.org> <20230816171538.GB26279@quicinc.com> <077c330d-5b86-4797-b69d-0ad02f49978f@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <077c330d-5b86-4797-b69d-0ad02f49978f@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: AG3g9nTiyKO_de7BG-zqCoI_5y3Saj0V X-Proofpoint-ORIG-GUID: AG3g9nTiyKO_de7BG-zqCoI_5y3Saj0V X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-18_29,2023-08-18_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 suspectscore=0 phishscore=0 clxscore=1015 mlxscore=0 spamscore=0 mlxlogscore=826 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308190015 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Aug 18 2023 10:33, Neil Armstrong wrote: > My opinion is that it would be a better idea to add a new output mode > to scripts/get_maintainer.pl than adding another script on top of it. Sorry, I don't follow. The problem that this script is solving is getting the output of `get_maintainer.pl` neatly into a patch according to this scheme: 1. Generate patches using `git format-patch` 2. Run `add-maintainer.py` on the above patches 3. `git send-email` the patches. Not sure how adding a new output mode to `get_maintainer.pl` fits in this problem space. Unless you mean to add a switch to it so that it automatically edits the patch in-place (like `add-maintainer.py` does) and adds all the addresses directly to the patch - in which case, that would be feature creep. > Or document somewhere how to use get_maintainer.pl with git-format-patch > without any additional scripts. IMHO, `Documentation/process/submitting-patches.rst` should be updated with at least one or two options addressing how to get from the aforementioned step #1 -> step #3 addressing the problem that is being solved by step #2. In this vacuum, every developer and maintainer appears to have their own solution that works for them. Thank you. Guru Das.