mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kartik <kkartik@nvidia.com>
To: <andriy.shevchenko@linux.intel.com>
Cc: <arnd@arndb.de>, <digetx@gmail.com>, <frank.li@vivo.com>,
	<jonathanh@nvidia.com>, <kkartik@nvidia.com>,
	<linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
	<pdeschrijver@nvidia.com>, <petlozup@nvidia.com>,
	<pshete@nvidia.com>, <robh@kernel.org>, <stefank@nvidia.com>,
	<sumitg@nvidia.com>, <thierry.reding@gmail.com>, <windhl@126.com>
Subject: Re: [PATCH 6/6] soc/tegra: fuse: Add support for Tegra241
Date: Mon, 21 Aug 2023 17:10:33 +0530	[thread overview]
Message-ID: <20230821114033.4446-1-kkartik@nvidia.com> (raw)
In-Reply-To: <ZN+Jzbsci3RLtEnW@smile.fi.intel.com>

On Fri, 2023-08-18 at 18:10 +0300, Andy Shevchenko wrote:
>On Fri, Aug 18, 2023 at 03:00:28PM +0530, Kartik wrote:
>> Add support for Tegra241 which use ACPI boot.
>
>...
>
>>  	case TEGRA234:
>>  		fuse->soc = &tegra234_fuse_soc;
>>  		break;
>> +#endif
>> +#if defined(CONFIG_ARCH_TEGRA_241_SOC)
>> +	case TEGRA241:
>> +		fuse->soc = &tegra241_fuse_soc;
>> +		break;
>>  #endif
>
>Have you tried --patience when formatting patches?
>Does it help them to look better?
>

No, I did not use --patience flag while formatting the patches.
Shall I post the next patch set using it?

>...
>
>> +const struct tegra_fuse_soc tegra241_fuse_soc = {
>> +	.init = tegra30_fuse_init,
>> +	.info = &tegra241_fuse_info,
>
>> +	.lookups = NULL,
>> +	.num_lookups = 0,
>> +	.cells = NULL,
>> +	.num_cells = 0,
>
>Isn't it the default?
>
>> +	.keepouts = tegra241_fuse_keepouts,
>> +	.num_keepouts = ARRAY_SIZE(tegra241_fuse_keepouts),
>> +	.soc_attr_group = &tegra194_soc_attr_group,
>
>> +	.clk_suspend_on = false,
>
>Ditto.
>

Yes, I will trim this list in the next patch.

>> +};

Regards,
Kartik

  reply	other threads:[~2023-08-21 11:41 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18  9:30 [PATCH 0/6] soc/tegra: fuse: Add ACPI support Kartik
2023-08-18  9:30 ` [PATCH 1/6] soc/tegra: fuse: Add tegra_acpi_init_apbmisc() Kartik
2023-08-18 13:21   ` Andy Shevchenko
2023-08-21 11:32     ` Kartik
2023-08-21 12:32       ` Andy Shevchenko
2023-08-22  7:52         ` Thierry Reding
2023-08-22  3:12   ` kernel test robot
2023-08-22  4:01   ` kernel test robot
2023-08-18  9:30 ` [PATCH 2/6] soc/tegra: fuse: Add function to register nvmem Kartik
2023-08-18 13:50   ` Andy Shevchenko
2023-08-21 11:34     ` Kartik
2023-08-18  9:30 ` [PATCH 3/6] soc/tegra: fuse: Add function to add lookups Kartik
2023-08-18 14:06   ` Andy Shevchenko
2023-08-21 11:36     ` Kartik
2023-08-18  9:30 ` [PATCH 4/6] soc/tegra: fuse: Add function to print SKU info Kartik
2023-08-22  7:55   ` Thierry Reding
2023-08-18  9:30 ` [PATCH 5/6] soc/tegra: fuse: Add ACPI support for Tegra194 and Tegra234 Kartik
2023-08-18 15:07   ` Andy Shevchenko
2023-08-21 11:38     ` Kartik
2023-08-21 12:45       ` Andy Shevchenko
2023-08-18  9:30 ` [PATCH 6/6] soc/tegra: fuse: Add support for Tegra241 Kartik
2023-08-18 15:10   ` Andy Shevchenko
2023-08-21 11:40     ` Kartik [this message]
2023-08-21 12:47       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230821114033.4446-1-kkartik@nvidia.com \
    --to=kkartik@nvidia.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=digetx@gmail.com \
    --cc=frank.li@vivo.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=pdeschrijver@nvidia.com \
    --cc=petlozup@nvidia.com \
    --cc=pshete@nvidia.com \
    --cc=robh@kernel.org \
    --cc=stefank@nvidia.com \
    --cc=sumitg@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=windhl@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome