From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Mel Gorman <mgorman@techsingularity.net>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 6/8] mm: page_alloc: fix move_freepages_block() range error
Date: Mon, 21 Aug 2023 14:33:38 -0400 [thread overview]
Message-ID: <20230821183733.106619-7-hannes@cmpxchg.org> (raw)
In-Reply-To: <20230821183733.106619-1-hannes@cmpxchg.org>
When a block is partially outside the zone of the cursor page, the
function cuts the range to the pivot page instead of the zone
start. This can leave large parts of the block behind, which
encourages incompatible page mixing down the line (ask for one type,
get another), and thus long-term fragmentation.
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 6a4004f07123..6fcda8e96f16 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1697,7 +1697,7 @@ int move_freepages_block(struct zone *zone, struct page *page,
/* Do not cross zone boundaries */
if (!zone_spans_pfn(zone, start_pfn))
- start_pfn = pfn;
+ start_pfn = zone->zone_start_pfn;
if (!zone_spans_pfn(zone, end_pfn))
return 0;
--
2.41.0
next prev parent reply other threads:[~2023-08-21 18:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 18:33 [PATCH 0/8] mm: page_alloc: freelist migratetype hygiene Johannes Weiner
2023-08-21 18:33 ` [PATCH 1/8] mm: page_alloc: use get_pfnblock_migratetype where pfn available Johannes Weiner
2023-08-21 20:14 ` Zi Yan
2023-08-21 20:29 ` Zi Yan
2023-08-21 21:22 ` Johannes Weiner
2023-08-21 18:33 ` [PATCH 2/8] mm: page_alloc: remove pcppage migratetype caching Johannes Weiner
2023-08-21 18:33 ` [PATCH 3/8] mm: page_alloc: fix highatomic landing on the wrong buddy list Johannes Weiner
2023-08-21 18:33 ` [PATCH 4/8] mm: page_alloc: fix up block types when merging compatible blocks Johannes Weiner
2023-08-21 20:41 ` Zi Yan
2023-08-21 21:20 ` Johannes Weiner
2023-08-21 18:33 ` [PATCH 5/8] mm: page_alloc: move free pages when converting block during isolation Johannes Weiner
2023-08-21 18:33 ` Johannes Weiner [this message]
2023-08-21 18:33 ` [PATCH 7/8] mm: page_alloc: fix freelist movement during block conversion Johannes Weiner
2023-08-21 18:33 ` [PATCH 8/8] mm: page_alloc: consolidate free page accounting Johannes Weiner
2023-08-23 22:40 ` kernel test robot
2023-08-24 1:34 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230821183733.106619-7-hannes@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®