From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8B8CDEE4993
	for <linux-kernel@archiver.kernel.org>; Tue, 22 Aug 2023 12:03:53 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235370AbjHVMDx (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 22 Aug 2023 08:03:53 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37406 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232308AbjHVMDw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Aug 2023 08:03:52 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A5A293
        for <linux-kernel@vger.kernel.org>; Tue, 22 Aug 2023 05:03:50 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature RSA-PSS (2048 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 3499D61EA3
        for <linux-kernel@vger.kernel.org>; Tue, 22 Aug 2023 12:03:50 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E9ECC433C8;
        Tue, 22 Aug 2023 12:03:49 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1692705829;
        bh=o0CAO/rJUxsXuZqz8OMH4p7eYcZMQ4fti8Kr4Nu533E=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=fk28g16m8GvoL8+NZW3s0+irekJLY6V0t21BeZRYnxZIkmtblq0ikSizyvC7yMDKp
         0N4kRZ4uzaRA9peLjPjP4dDplJTxmlWw/tFWtHSC2tOap6DCSSlTZZXFTA8r4IHSGb
         JVERt4/0+1dgCF94fXm+6zRfKTEOsXIHeoi9p4p8=
Date:   Tue, 22 Aug 2023 14:03:46 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     "GONG, Ruiqi" <gongruiqi@huaweicloud.com>
Cc:     Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
        linux-kernel@vger.kernel.org, gongruiqi1@huawei.com
Subject: Re: [PATCH] lkdtm: use the return value of strim()
Message-ID: <2023082228-breath-submitter-7a1e@gregkh>
References: <20230817142117.972418-1-gongruiqi@huaweicloud.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230817142117.972418-1-gongruiqi@huaweicloud.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 17, 2023 at 10:21:17PM +0800, GONG, Ruiqi wrote:
> From: "GONG, Ruiqi" <gongruiqi1@huawei.com>
> 
> Make use of the return value of strim() to achieve left-trim as well as
> right-trim, which prevents the following unusual fail case:
> 
>  # echo " EXCEPTION" > /sys/kernel/debug/provoke-crash/DIRECT
>  sh: write error: Invalid argument

And that is correct, don't use leading whitespace, the kernel is not
there to parse it away :)

thanks,

greg k-h