From: Rick Edgecombe <rick.p.edgecombe@intel.com>
To: lkp@intel.com
Cc: bp@alien8.de, dave.hansen@linux.intel.com, keescook@chromium.org,
linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev,
rick.p.edgecombe@intel.com, x86@kernel.org,
yu-cheng.yu@intel.com
Subject: [PATCH] x86/shstk: Change order of __user in type
Date: Thu, 24 Aug 2023 18:45:54 -0700 [thread overview]
Message-ID: <20230825014554.1769194-1-rick.p.edgecombe@intel.com> (raw)
In-Reply-To: <202308222312.Jt4Tog5T-lkp@intel.com>
0day reports a sparse warning:
arch/x86/kernel/shstk.c:295:55: sparse: sparse: cast removes address space
'__user' of expression
The __user is in the wrong spot. Move it to right spot and make sparse
happy.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308222312.Jt4Tog5T-lkp@intel.com/
Signed-off-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
---
arch/x86/kernel/shstk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/shstk.c b/arch/x86/kernel/shstk.c
index cd10d074a444..fd689921a1db 100644
--- a/arch/x86/kernel/shstk.c
+++ b/arch/x86/kernel/shstk.c
@@ -275,7 +275,7 @@ static int shstk_push_sigframe(unsigned long *ssp)
return -EINVAL;
*ssp -= SS_FRAME_SIZE;
- if (put_shstk_data((void *__user)*ssp, target_ssp))
+ if (put_shstk_data((void __user *)*ssp, target_ssp))
return -EFAULT;
return 0;
--
2.34.1
next prev parent reply other threads:[~2023-08-25 1:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 15:30 [tip:x86/shstk 10/24] arch/x86/kernel/shstk.c:244:29: sparse: sparse: incorrect type in argument 1 (different address spaces) kernel test robot
2023-08-25 1:45 ` Rick Edgecombe [this message]
2023-08-25 21:21 ` [PATCH] x86/shstk: Change order of __user in type Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825014554.1769194-1-rick.p.edgecombe@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=x86@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®