From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C3D4C7EE2C for ; Fri, 25 Aug 2023 11:22:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240370AbjHYLVd (ORCPT ); Fri, 25 Aug 2023 07:21:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243328AbjHYLV0 (ORCPT ); Fri, 25 Aug 2023 07:21:26 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B7111FDE for ; Fri, 25 Aug 2023 04:20:57 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3fee87dd251so7245235e9.2 for ; Fri, 25 Aug 2023 04:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692962456; x=1693567256; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LyVYlwAqgLBhb9pjXnI3VdwK+OmQBeJAxGPkhMUt9do=; b=xAzctQaaqWDUp/VW4HIk1k0poq1PDBIxGK49RQY+IOkgmWhyxP/3Fpv6X4Ed8tn0C3 t3+z5TVE9tiAQrQizBbkKgl5VOqge1qy4fJoeNG5wgqLaqxnRw3HxTDjDdOm3BaAbQ7L AdjTRBhbhStpyO5ZGkItbyeYzTQDWtJRkKATLP7jpieaNTREt87LSCHGaJ8PB3k90KSX RKUPzY7pYeVDIBTVoMIOAiak5S1uTsPGZc9yh6GhzW/F2ied97mVGIRP36cpImKhHrvz AwC/uVS3HSCnl8TJIx2vz+yZYvhmYXTPL8yUT7P4/JO28ixTpWtg0j8LgjG07QsFDid5 JmsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692962456; x=1693567256; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LyVYlwAqgLBhb9pjXnI3VdwK+OmQBeJAxGPkhMUt9do=; b=XmHw9ssStVdRegCi7GHDg1d9t25/aIXE/QsQ+vGccJySPYIJBm72M303ZIiqiMHoEY ZmgOOhef93NS/l+amifU1zsKUw/c8VlepoaJRCAFoEbhN5UlNo23CIzKw0gjPHDA1d9J yz7HxNoRjEVuSuvhz6IG2/XC7SN9BOVw5Cya7PsEA8m+o6wzcIsIIZKuDR/FZe8z5X+3 EFYlArdM9C09eyezSJb7yrxBAXeM8NDYfMr5HoIyJWA42DjQ5XH3RYu6vtMKL+ei9g11 BIBaBcAPK0TbNWhuC3JX0XooppdBtqFfR6qwoHbyk4gS5gR1TWe/iqQYknGHyR/cHBGE 7asQ== X-Gm-Message-State: AOJu0YxpJslrfFLR8VGN2AzwDYFvv5Nq7CmXi0SKsCtc34mHqVw46sFS 5mBp8I/3YV8ADN9rlK08L93Liw== X-Google-Smtp-Source: AGHT+IF4F+IhpNhFa0LEait9G/lVg93DLllxE8WUtCFepSGG51mVVPFuUrfL9VTKvfSysAM94nTvWw== X-Received: by 2002:adf:fd4e:0:b0:313:ef08:c83b with SMTP id h14-20020adffd4e000000b00313ef08c83bmr12573907wrs.56.1692962455985; Fri, 25 Aug 2023 04:20:55 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id n12-20020a5d67cc000000b00317afc7949csm1950082wrw.50.2023.08.25.04.20.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Aug 2023 04:20:55 -0700 (PDT) Date: Fri, 25 Aug 2023 12:20:53 +0100 From: Daniel Thompson To: Douglas Anderson Cc: Mark Rutland , Catalin Marinas , Will Deacon , Sumit Garg , Marc Zyngier , "Rafael J . Wysocki" , Ard Biesheuvel , Thomas Gleixner , kgdb-bugreport@lists.sourceforge.net, Lecopzer Chen , linux-perf-users@vger.kernel.org, Masayoshi Mizuma , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, ito-yuichi@fujitsu.com, Stephen Boyd , Peter Zijlstra , D Scott Phillips , Josh Poimboeuf , Valentin Schneider , linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 6/6] arm64: kgdb: Implement kgdb_roundup_cpus() to enable pseudo-NMI roundup Message-ID: <20230825112053.GE270740@aspen.lan> References: <20230824153233.1006420-1-dianders@chromium.org> <20230824083012.v11.6.I2ef26d1b3bfbed2d10a281942b0da7d9854de05e@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230824083012.v11.6.I2ef26d1b3bfbed2d10a281942b0da7d9854de05e@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 24, 2023 at 08:30:32AM -0700, Douglas Anderson wrote: > Up until now we've been using the generic (weak) implementation for > kgdb_roundup_cpus() when using kgdb on arm64. Let's move to a custom > one. The advantage here is that, when pseudo-NMI is enabled on a > device, we'll be able to round up CPUs using pseudo-NMI. This allows > us to debug CPUs that are stuck with interrupts disabled. If > pseudo-NMIs are not enabled then we'll fallback to just using an IPI, > which is still slightly better than the generic implementation since > it avoids the potential situation described in the generic > kgdb_call_nmi_hook(). > > Co-developed-by: Sumit Garg > Signed-off-by: Sumit Garg > Signed-off-by: Douglas Anderson >From a kgdb point of view: Reviewed-by: Daniel Thompson Daniel.