From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-pci@vger.kernel.org, "Bjorn Helgaas" <helgaas@kernel.org>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Chas Williams" <3chas3@gmail.com>,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v2 4/8] atm: iphase: Do PCI error checks on own line
Date: Sun, 27 Aug 2023 16:37:01 +0300 [thread overview]
Message-ID: <20230827133705.12991-5-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20230827133705.12991-1-ilpo.jarvinen@linux.intel.com>
In get_esi() PCI errors are checked inside line-split if conditions (in
addition to the file not following the coding style). To make the code
in get_esi() more readable, fix the coding style and use the usual
error handling pattern with a separate variable.
In addition, initialization of 'error' variable at declaration is not
needed.
No function changes intended.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
drivers/atm/iphase.c | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index 324148686953..9bba8f280a4d 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -2291,19 +2291,21 @@ static int get_esi(struct atm_dev *dev)
static int reset_sar(struct atm_dev *dev)
{
IADEV *iadev;
- int i, error = 1;
+ int i, error;
unsigned int pci[64];
iadev = INPH_IA_DEV(dev);
- for(i=0; i<64; i++)
- if ((error = pci_read_config_dword(iadev->pci,
- i*4, &pci[i])) != PCIBIOS_SUCCESSFUL)
- return error;
+ for (i = 0; i < 64; i++) {
+ error = pci_read_config_dword(iadev->pci, i * 4, &pci[i]);
+ if (error != PCIBIOS_SUCCESSFUL)
+ return error;
+ }
writel(0, iadev->reg+IPHASE5575_EXT_RESET);
- for(i=0; i<64; i++)
- if ((error = pci_write_config_dword(iadev->pci,
- i*4, pci[i])) != PCIBIOS_SUCCESSFUL)
- return error;
+ for (i = 0; i < 64; i++) {
+ error = pci_write_config_dword(iadev->pci, i * 4, pci[i]);
+ if (error != PCIBIOS_SUCCESSFUL)
+ return error;
+ }
udelay(5);
return 0;
}
--
2.30.2
next prev parent reply other threads:[~2023-08-27 13:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-27 13:36 [PATCH v2 0/8] PCI/treewide: Cleanup/streamline PCI error code handling Ilpo Järvinen
2023-08-27 13:36 ` [PATCH v2 1/8] alpha: Streamline convoluted PCI error handling Ilpo Järvinen
2023-08-27 13:36 ` [PATCH v2 2/8] MIPS: TXx9: Do PCI error checks on own line Ilpo Järvinen
2023-08-28 9:10 ` Thomas Bogendoerfer
2023-08-27 13:37 ` [PATCH v2 3/8] sh: pci: Do PCI error check " Ilpo Järvinen
2023-08-27 13:37 ` Ilpo Järvinen [this message]
2023-08-27 13:37 ` [PATCH v2 5/8] I2C: ali15x3: Do PCI error checks " Ilpo Järvinen
2023-08-28 22:10 ` Andi Shyti
2023-08-30 19:18 ` Wolfram Sang
2023-08-27 13:37 ` [PATCH v2 6/8] PCI: Do error check on own line to split long if conditions Ilpo Järvinen
2023-08-27 13:37 ` [PATCH v2 7/8] PCI: xgene: Do PCI error check on own line Ilpo Järvinen
2023-08-29 16:05 ` Rob Herring
2023-08-29 16:14 ` Ilpo Järvinen
2023-08-29 16:23 ` Ilpo Järvinen
2023-08-27 13:37 ` [PATCH v2 8/8] scsi: ipr: Do PCI error checks " Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230827133705.12991-5-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=3chas3@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=helgaas@kernel.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=philmd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®