From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 693E8C83F11 for ; Mon, 28 Aug 2023 16:39:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230443AbjH1QjY (ORCPT ); Mon, 28 Aug 2023 12:39:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231573AbjH1QjT (ORCPT ); Mon, 28 Aug 2023 12:39:19 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46A6EF9 for ; Mon, 28 Aug 2023 09:39:17 -0700 (PDT) Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 49E7D5AA; Mon, 28 Aug 2023 18:37:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1693240674; bh=l1xYuLhYKsgSs0UaqJUnGbUJuxaauT0l+VB86QnqciI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U2LXTCRDc4Cc9G+ZJ+vVF5paaE0JAC4bRkYgtLDR64dUEfJ4cEZxmTn1ybF/PIXWf taDlSuB0RkLmQ/9cDcemc9y5K7zImS2WTkQ26/m2A7BtNYV3hjI1bu6KwuMZa0vW6n 1Gp7sSDtdsRDNMXPINO/ca1/Y3b0iqqAB115maAI= Date: Mon, 28 Aug 2023 19:39:25 +0300 From: Laurent Pinchart To: Lee Jones Cc: linux-kernel@vger.kernel.org, Hyun Kwon , David Airlie , Daniel Vetter , Michal Simek , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp Message-ID: <20230828163925.GU14596@pendragon.ideasonboard.com> References: <20230824073710.2677348-1-lee@kernel.org> <20230824073710.2677348-2-lee@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230824073710.2677348-2-lee@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, Thank you for the patch. On Thu, Aug 24, 2023 at 08:36:46AM +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'blend' not described in 'zynqmp_disp' > drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'avbuf' not described in 'zynqmp_disp' > drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'audio' not described in 'zynqmp_disp' > > Signed-off-by: Lee Jones > --- > Cc: Hyun Kwon > Cc: Laurent Pinchart > Cc: David Airlie > Cc: Daniel Vetter > Cc: Michal Simek > Cc: dri-devel@lists.freedesktop.org > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c > index 407bc07cec69a..7c64ab11fe2b0 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c > @@ -128,9 +128,9 @@ struct zynqmp_disp_layer { > * struct zynqmp_disp - Display controller > * @dev: Device structure > * @dpsub: Display subsystem > - * @blend.base: Register I/O base address for the blender > - * @avbuf.base: Register I/O base address for the audio/video buffer manager > - * @audio.base: Registers I/O base address for the audio mixer > + * @blend: .base: Register I/O base address for the blender > + * @avbuf: .base: Register I/O base address for the audio/video buffer manager > + * @audio: .base: Registers I/O base address for the audio mixer This is really a hack to work around the warning, and not a clean fix. kerneldoc is still today unable, as far as I understand, to document nested structures. That's annoying, and the warning is a good way to remind us that it needs to be fixed. I'd be tempted to keep the warning for that reason. > * @layers: Layers (planes) > */ > struct zynqmp_disp { -- Regards, Laurent Pinchart