From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4F72C83F12 for ; Tue, 29 Aug 2023 15:06:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237058AbjH2PF6 (ORCPT ); Tue, 29 Aug 2023 11:05:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237051AbjH2PFa (ORCPT ); Tue, 29 Aug 2023 11:05:30 -0400 Received: from outbound-smtp39.blacknight.com (outbound-smtp39.blacknight.com [46.22.139.222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F20C6D7 for ; Tue, 29 Aug 2023 08:05:27 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp39.blacknight.com (Postfix) with ESMTPS id 96FBB1B24 for ; Tue, 29 Aug 2023 16:05:26 +0100 (IST) Received: (qmail 20754 invoked from network); 29 Aug 2023 15:05:26 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.20.191]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 29 Aug 2023 15:05:26 -0000 Date: Tue, 29 Aug 2023 16:05:23 +0100 From: Mel Gorman To: Kemeng Shi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, david@redhat.com, willy@infradead.org Subject: Re: [PATCH v2 5/7] mm/compaction: remove repeat compact_blockskip_flush check in reset_isolation_suitable Message-ID: <20230829150523.ktn6ktdtl7n22akp@techsingularity.net> References: <20230826153617.4019189-1-shikemeng@huaweicloud.com> <20230826153617.4019189-6-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230826153617.4019189-6-shikemeng@huaweicloud.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 26, 2023 at 11:36:15PM +0800, Kemeng Shi wrote: > We have compact_blockskip_flush check in __reset_isolation_suitable, just > remove repeat check before __reset_isolation_suitable in > compact_blockskip_flush. > > Signed-off-by: Kemeng Shi > Reviewed-by: Baolin Wang The comment should move to __reset_isolation_suitable but otherwise Acked-by: Mel Gorman As a complete aside, the reset_isolation_suitable and __reset_isolation_suitable were badly named because locking is not involved but it's meaningless churn to fix it. -- Mel Gorman SUSE Labs