From: Lukasz Majewski <lukma@denx.de>
To: Eric Dumazet <edumazet@google.com>, Andrew Lunn <andrew@lunn.ch>,
davem@davemloft.net, Woojung Huh <woojung.huh@microchip.com>,
Vladimir Oltean <olteanv@gmail.com>,
Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Tristram.Ha@microchip.com,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
UNGLinuxDriver@microchip.com,
Russell King <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Lukasz Majewski <lukma@denx.de>
Subject: [PATCH 2/2] net: phy: Provide Module 4 KSZ9477 errata (DS80000754C)
Date: Wed, 30 Aug 2023 11:21:19 +0200 [thread overview]
Message-ID: <20230830092119.458330-2-lukma@denx.de> (raw)
In-Reply-To: <20230830092119.458330-1-lukma@denx.de>
The KSZ9477 errata points out (in 'Module 4') the link up/down problem
when EEE (Energy Efficient Ethernet) is enabled in the device to which
the KSZ9477 tries to auto negotiate.
The suggested workaround is to clear advertisement of EEE for PHYs in
this chip driver.
Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
drivers/net/phy/micrel.c | 31 ++++++++++++++++++++++++++++++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 87b090ad2874..469dcd8a5711 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -1418,6 +1418,35 @@ static int ksz9131_get_features(struct phy_device *phydev)
return 0;
}
+static int ksz9477_get_features(struct phy_device *phydev)
+{
+ __ETHTOOL_DECLARE_LINK_MODE_MASK(zero) = { 0, };
+ int ret;
+
+ ret = genphy_read_abilities(phydev);
+ if (ret)
+ return ret;
+
+ /* KSZ9477 Errata DS80000754C
+ *
+ * Module 4: Energy Efficient Ethernet (EEE) feature select must be
+ * manually disabled
+ * The EEE feature is enabled by default, but it is not fully
+ * operational. It must be manually disabled through register
+ * controls. If not disabled, the PHY ports can auto-negotiate
+ * to enable EEE, and this feature can cause link drops when linked
+ * to another device supporting EEE.
+ *
+ * Although, the KSZ9477 MMD register
+ * (MMD_DEVICE_ID_EEE_ADV.MMD_EEE_ADV) advertise that EEE is
+ * operational one needs to manualy clear them to follow the chip
+ * errata.
+ */
+ linkmode_and(phydev->supported_eee, phydev->supported, zero);
+
+ return 0;
+}
+
#define KSZ8873MLL_GLOBAL_CONTROL_4 0x06
#define KSZ8873MLL_GLOBAL_CONTROL_4_DUPLEX BIT(6)
#define KSZ8873MLL_GLOBAL_CONTROL_4_SPEED BIT(4)
@@ -4871,7 +4900,7 @@ static struct phy_driver ksphy_driver[] = {
.handle_interrupt = kszphy_handle_interrupt,
.suspend = genphy_suspend,
.resume = genphy_resume,
- .get_features = ksz9131_get_features,
+ .get_features = ksz9477_get_features,
} };
module_phy_driver(ksphy_driver);
--
2.20.1
next prev parent reply other threads:[~2023-08-30 19:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 9:21 [PATCH 1/2] net: phy: Rename KSZ9477 get features function (to ksz9131_get_features) Lukasz Majewski
2023-08-30 9:21 ` Lukasz Majewski [this message]
2023-08-30 9:48 ` [PATCH 2/2] net: phy: Provide Module 4 KSZ9477 errata (DS80000754C) Michal Swiatkowski
2023-08-30 10:37 ` Lukasz Majewski
2023-08-30 10:18 ` Oleksij Rempel
2023-08-30 10:52 ` Lukasz Majewski
2023-08-30 10:59 ` Oleksij Rempel
2023-08-30 11:51 ` Lukasz Majewski
2023-08-30 12:17 ` Oleksij Rempel
2023-08-30 12:35 ` Russell King (Oracle)
2023-08-30 13:06 ` Oleksij Rempel
2023-08-30 13:30 ` Russell King (Oracle)
2023-08-30 14:26 ` Oleksij Rempel
2023-08-30 14:38 ` Russell King (Oracle)
2023-08-30 14:48 ` Oleksij Rempel
2023-08-30 16:38 ` Lukasz Majewski
2023-08-31 4:40 ` Oleksij Rempel
2023-08-31 7:13 ` Russell King (Oracle)
2023-08-30 13:23 ` Lukasz Majewski
2023-08-30 11:20 ` Russell King (Oracle)
2023-08-30 11:08 ` Russell King (Oracle)
2023-08-30 11:20 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230830092119.458330-2-lukma@denx.de \
--to=lukma@denx.de \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®