From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FE7EC83F15 for ; Wed, 30 Aug 2023 19:32:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242670AbjH3Tb6 (ORCPT ); Wed, 30 Aug 2023 15:31:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245214AbjH3OtB (ORCPT ); Wed, 30 Aug 2023 10:49:01 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0E7FFF for ; Wed, 30 Aug 2023 07:48:58 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbMUi-0008Eb-CP; Wed, 30 Aug 2023 16:48:32 +0200 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1qbMUh-0007WD-Ax; Wed, 30 Aug 2023 16:48:31 +0200 Date: Wed, 30 Aug 2023 16:48:31 +0200 From: Oleksij Rempel To: "Russell King (Oracle)" Cc: Lukasz Majewski , Eric Dumazet , Andrew Lunn , davem@davemloft.net, Woojung Huh , Vladimir Oltean , Tristram.Ha@microchip.com, Florian Fainelli , Jakub Kicinski , Paolo Abeni , UNGLinuxDriver@microchip.com, Heiner Kallweit , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] net: phy: Provide Module 4 KSZ9477 errata (DS80000754C) Message-ID: <20230830144831.GM31399@pengutronix.de> References: <20230830101813.GG31399@pengutronix.de> <20230830125224.1012459f@wsk> <20230830105941.GH31399@pengutronix.de> <20230830135151.683303db@wsk> <20230830121738.GJ31399@pengutronix.de> <20230830130649.GK31399@pengutronix.de> <20230830142650.GL31399@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 30, 2023 at 03:38:55PM +0100, Russell King (Oracle) wrote: > On Wed, Aug 30, 2023 at 04:26:50PM +0200, Oleksij Rempel wrote: > > @Lukasz, > > > > can you please try to set eee_broken_modes to all-ones. Somewhat like > > this: > > ksz9477_config_init() > > ... > > ...quirks... > > > > if (phydev->dev_flages & .. NO_EEE...) > > phydev->eee_broken_modes = -1; > > That's fine in config_init(). > > > err = genphy_restart_aneg(phydev); > > That isn't necessary, and in any case, calling it will just cause the > AN enable and AN restart bits in BMCR to be set, nothing will be > reprogrammed. ack. It is already existing code, see: https://elixir.bootlin.com/linux/v6.5/source/drivers/net/phy/micrel.c#L1822 Setting eee_broken_modes probably can be done at any plaice in this function. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |