From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6268C83F2E for ; Wed, 30 Aug 2023 19:23:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244437AbjH3TVZ (ORCPT ); Wed, 30 Aug 2023 15:21:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245273AbjH3PBQ (ORCPT ); Wed, 30 Aug 2023 11:01:16 -0400 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E92FE1A2 for ; Wed, 30 Aug 2023 08:01:13 -0700 (PDT) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 37U7gEVE026115; Wed, 30 Aug 2023 10:00:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=PODMain02222019; bh=nY6mVvv6rW6BhL4 MqzQFYP/NvGfCvBh5V3UfYUMt3Qc=; b=STvijXg8VhtiCnXcKhtViWah2cFCb2w hipYvB/Xhno62yxDTxCb6e3aVIsWXxLZUZNFWT/GD+/zdGkhZ788C2Xvwo/4NxEL JsNf1URvi2HaZGcLV6rdAdmltF274DDr7/rqu4ij5nO9oQsC5DTcPlO/jIa49Brn FLx23DwLcoKNY3ruu0L+X4ZdR1wwGVKWO3J7u3B3nWUyzvUIb+IK2IjCje5yTbC5 kklzbWUq+RqjJ6WQVrGMBxwg/RRo3hGmC2lVkhwA6F0xsNCjYogRtZp5H732XwXp aD63dgYXQAXq2MbOa6p0zdraSuSbmf6zOxPE6/bepdaruNFaVWbR1XA== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3sqesyd38v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Aug 2023 10:00:40 -0500 (CDT) Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Wed, 30 Aug 2023 16:00:38 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.2.1118.37 via Frontend Transport; Wed, 30 Aug 2023 16:00:38 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id E6F183561; Wed, 30 Aug 2023 15:00:37 +0000 (UTC) Date: Wed, 30 Aug 2023 15:00:37 +0000 From: Charles Keepax To: Takashi Iwai CC: "Sudip Mukherjee (Codethink)" , James Schulman , David Rhodes , "Richard Fitzgerald" , Lee Jones , , , , Linus Torvalds , Subject: Re: mainline build failure due to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver") Message-ID: <20230830150037.GW103419@ediswmail.ad.cirrus.com> References: <87cyz4he2u.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <87cyz4he2u.wl-tiwai@suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-ORIG-GUID: NK8Mq90hyYK6qZ7mtTDHX5VrG2uIuS3d X-Proofpoint-GUID: NK8Mq90hyYK6qZ7mtTDHX5VrG2uIuS3d X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 30, 2023 at 03:09:13PM +0200, Takashi Iwai wrote: > On Wed, 30 Aug 2023 13:29:57 +0200, > Sudip Mukherjee (Codethink) wrote: > > > > Hi All, > > > > The latest mainline kernel branch fails to build alpha, csky and s390 > > allmodconfig with the error: > > > > drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but not used [-Werror=unused-function] > > 1138 | static int cs42l43_runtime_resume(struct device *dev) > > | ^~~~~~~~~~~~~~~~~~~~~~ > > drivers/mfd/cs42l43.c:1124:12: error: 'cs42l43_runtime_suspend' defined but not used [-Werror=unused-function] > > 1124 | static int cs42l43_runtime_suspend(struct device *dev) > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > drivers/mfd/cs42l43.c:1106:12: error: 'cs42l43_resume' defined but not used [-Werror=unused-function] > > 1106 | static int cs42l43_resume(struct device *dev) > > | ^~~~~~~~~~~~~~ > > drivers/mfd/cs42l43.c:1076:12: error: 'cs42l43_suspend' defined but not used [-Werror=unused-function] > > 1076 | static int cs42l43_suspend(struct device *dev) > > | ^~~~~~~~~~~~~~~ > > > > git bisect pointed to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver") > > > > I will be happy to test any patch or provide any extra log if needed. > > Adding __maybe_unused for those PM functions should work around it, > something like below. Could you check it? > If it's confirmed to work, I'll submit properly. > > This is probably the correct fix: https://lore.kernel.org/lkml/20230822114914.340359-1-ckeepax@opensource.cirrus.com/ Just waiting on it to be reviewed. Thanks, Charles