From: Dembskiy Igor <dii@itb.spb.ru>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Dembskiy Igor <dii@itb.spb.ru>,
Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Akinobu Mita <akinobu.mita@gmail.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: [PATCH] mtd: tests: remove useless checks
Date: Fri, 1 Sep 2023 16:36:41 +0300 [thread overview]
Message-ID: <20230901133641.60817-1-dii@itb.spb.ru> (raw)
Return value of mtdtest_scan_for_bad_() is always 0. So it causes senseless
checks in some functions such as mtd_subpagetest_init().
Fixes: 084db4b020c7 ("mtd: tests: introduce helper functions")
Signed-off-by: Dembskiy Igor <dii@itb.spb.ru>
---
drivers/mtd/tests/oobtest.c | 2 --
drivers/mtd/tests/pagetest.c | 2 --
drivers/mtd/tests/readtest.c | 2 --
drivers/mtd/tests/speedtest.c | 3 +--
drivers/mtd/tests/stresstest.c | 2 --
drivers/mtd/tests/subpagetest.c | 2 --
drivers/mtd/tests/torturetest.c | 2 --
7 files changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/mtd/tests/oobtest.c b/drivers/mtd/tests/oobtest.c
index 13fed398937e..976f40a5656e 100644
--- a/drivers/mtd/tests/oobtest.c
+++ b/drivers/mtd/tests/oobtest.c
@@ -399,8 +399,6 @@ static int __init mtd_oobtest_init(void)
pr_info("test 1 of 5\n");
err = mtdtest_erase_good_eraseblocks(mtd, bbt, 0, ebcnt);
- if (err)
- goto out;
prandom_seed_state(&rnd_state, 1);
err = write_whole_device();
diff --git a/drivers/mtd/tests/pagetest.c b/drivers/mtd/tests/pagetest.c
index 8eb40b6e6dfa..a59ef88cdaf3 100644
--- a/drivers/mtd/tests/pagetest.c
+++ b/drivers/mtd/tests/pagetest.c
@@ -373,8 +373,6 @@ static int __init mtd_pagetest_init(void)
if (!bbt)
goto out;
err = mtdtest_scan_for_bad_eraseblocks(mtd, bbt, 0, ebcnt);
- if (err)
- goto out;
/* Erase all eraseblocks */
pr_info("erasing whole device\n");
diff --git a/drivers/mtd/tests/readtest.c b/drivers/mtd/tests/readtest.c
index 99670ef91f2b..8bc52aca1b2a 100644
--- a/drivers/mtd/tests/readtest.c
+++ b/drivers/mtd/tests/readtest.c
@@ -162,8 +162,6 @@ static int __init mtd_readtest_init(void)
if (!bbt)
goto out;
err = mtdtest_scan_for_bad_eraseblocks(mtd, bbt, 0, ebcnt);
- if (err)
- goto out;
/* Read all eraseblocks 1 page at a time */
pr_info("testing page read\n");
diff --git a/drivers/mtd/tests/speedtest.c b/drivers/mtd/tests/speedtest.c
index 075bce32caa5..978369f8d4c0 100644
--- a/drivers/mtd/tests/speedtest.c
+++ b/drivers/mtd/tests/speedtest.c
@@ -229,8 +229,7 @@ static int __init mtd_speedtest_init(void)
if (!bbt)
goto out;
err = mtdtest_scan_for_bad_eraseblocks(mtd, bbt, 0, ebcnt);
- if (err)
- goto out;
+
for (i = 0; i < ebcnt; i++) {
if (!bbt[i])
goodebcnt++;
diff --git a/drivers/mtd/tests/stresstest.c b/drivers/mtd/tests/stresstest.c
index 8062098930d6..0a1fa8a2078e 100644
--- a/drivers/mtd/tests/stresstest.c
+++ b/drivers/mtd/tests/stresstest.c
@@ -189,8 +189,6 @@ static int __init mtd_stresstest_init(void)
if (!bbt)
goto out;
err = mtdtest_scan_for_bad_eraseblocks(mtd, bbt, 0, ebcnt);
- if (err)
- goto out;
/* Do operations */
pr_info("doing operations\n");
diff --git a/drivers/mtd/tests/subpagetest.c b/drivers/mtd/tests/subpagetest.c
index 05250a080139..5ca93e169a25 100644
--- a/drivers/mtd/tests/subpagetest.c
+++ b/drivers/mtd/tests/subpagetest.c
@@ -319,8 +319,6 @@ static int __init mtd_subpagetest_init(void)
goto out;
err = mtdtest_scan_for_bad_eraseblocks(mtd, bbt, 0, ebcnt);
- if (err)
- goto out;
err = mtdtest_erase_good_eraseblocks(mtd, bbt, 0, ebcnt);
if (err)
diff --git a/drivers/mtd/tests/torturetest.c b/drivers/mtd/tests/torturetest.c
index 841689b4d86d..46634198e19d 100644
--- a/drivers/mtd/tests/torturetest.c
+++ b/drivers/mtd/tests/torturetest.c
@@ -243,8 +243,6 @@ static int __init tort_init(void)
}
err = mtdtest_scan_for_bad_eraseblocks(mtd, bad_ebs, eb, ebcnt);
- if (err)
- goto out;
start_timing();
while (1) {
--
2.34.1
next reply other threads:[~2023-09-01 13:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 13:36 Dembskiy Igor [this message]
2023-09-01 13:42 ` Miquel Raynal
2023-09-02 10:32 ` Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230901133641.60817-1-dii@itb.spb.ru \
--to=dii@itb.spb.ru \
--cc=akinobu.mita@gmail.com \
--cc=bbrezillon@kernel.org \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lvc-project@linuxtesting.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®