From: Pawel Zmarzly <pzmarzly@meta.com>
To: <Niklas.Cassel@wdc.com>
Cc: Damien Le Moal <dlemoal@kernel.org>, <linux-ide@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Pawel Zmarzly <pzmarzly@meta.com>
Subject: [PATCH v3] ata: Disable NCQ_TRIM on Micron 1100 drives
Date: Fri, 1 Sep 2023 13:02:21 -0700 [thread overview]
Message-ID: <20230901200220.3891806-1-pzmarzly@meta.com> (raw)
In-Reply-To: <ZPIyxg+iSWa+W93Q@x1-carbon>
Micron 1100 drives lock up when encountering queued TRIM command.
It is a quite old hardware series, for past years we have been
running our machines with these drives using
libata.force=noncqtrim.
Signed-off-by: Pawel Zmarzly <pzmarzly@meta.com>
---
V1 -> V2: Fixed formatting.
V2 -> V3: Added missing Signed off line. Sorry, this is my
first time upstreaming.
drivers/ata/libata-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 175b2a9dc000..116f5fd6e3f7 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4564,6 +4564,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
ATA_HORKAGE_ZERO_AFTER_TRIM, },
{ "FCCT*M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
ATA_HORKAGE_ZERO_AFTER_TRIM, },
+ { "Micron_1100_*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
+ ATA_HORKAGE_ZERO_AFTER_TRIM, },
/* devices that don't properly handle TRIM commands */
{ "SuperSSpeed S238*", NULL, ATA_HORKAGE_NOTRIM, },
--
2.39.3
next prev parent reply other threads:[~2023-09-01 20:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 0:02 [PATCH] " Pawel Zmarzly
2023-09-01 9:49 ` Niklas Cassel
2023-09-01 18:23 ` [PATCH v2] " Pawel Zmarzly
2023-09-01 18:51 ` Niklas Cassel
2023-09-01 20:02 ` Pawel Zmarzly [this message]
2023-09-01 20:19 ` [PATCH v3] " Niklas Cassel
2023-09-02 2:54 ` Damien Le Moal
2023-09-02 3:11 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230901200220.3891806-1-pzmarzly@meta.com \
--to=pzmarzly@meta.com \
--cc=Niklas.Cassel@wdc.com \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®