From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B14F5C71153 for ; Mon, 4 Sep 2023 09:52:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352684AbjIDJwB (ORCPT ); Mon, 4 Sep 2023 05:52:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231742AbjIDJv7 (ORCPT ); Mon, 4 Sep 2023 05:51:59 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 01BF111D; Mon, 4 Sep 2023 02:51:55 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4C0251042; Mon, 4 Sep 2023 02:52:33 -0700 (PDT) Received: from localhost.localdomain (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 00E433F793; Mon, 4 Sep 2023 02:51:51 -0700 (PDT) From: James Clark To: linux-perf-users@vger.kernel.org, irogers@google.com Cc: James Clark , John Garry , Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kajol Jain , Haixin Yu , Jing Zhang , Ravi Bangoria , Kan Liang , Yang Jihong , Eduard Zingerman , Chen Zhongjin , Miguel Ojeda , Liam Howlett , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 0/7] perf: strcmp_cpuid_str() expression fixups Date: Mon, 4 Sep 2023 10:50:42 +0100 Message-Id: <20230904095104.1162928-1-james.clark@arm.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Set of fixes related to the comments here [1]. Mainly cleanups, additional tests and refactoring since adding the new strcmp_cpuid_str() metric expression. I added the string replace function to the perf utils rather than tools/lib/string.c because it didn't seem easy to add tests for tools/lib. [1]: https://lore.kernel.org/linux-arm-kernel/CAP-5=fVnUx0BnJC7X1rrm42OD7Bk=ZsHWNwAZMBYyB7yWhBfhQ@mail.gmail.com/ --- Changes since v1: * s -> haystack * find -> needle James Clark (7): perf test: Check result of has_event(cycles) test perf jevents: Remove unused keyword perf util: Add a function for replacing characters in a string perf test: Add a test for strcmp_cpuid_str() expression perf pmu: Move pmu__find_core_pmu() to pmus.c perf pmus: Simplify perf_pmus__find_core_pmu() perf pmu: Remove unused function tools/perf/arch/arm64/util/pmu.c | 20 ++++++------- tools/perf/pmu-events/metric.py | 3 +- tools/perf/tests/Build | 1 + tools/perf/tests/builtin-test.c | 1 + tools/perf/tests/expr.c | 33 ++++++++++++++++++---- tools/perf/tests/tests.h | 1 + tools/perf/tests/util.c | 31 +++++++++++++++++++++ tools/perf/util/expr.c | 2 +- tools/perf/util/pmu.c | 22 --------------- tools/perf/util/pmu.h | 3 +- tools/perf/util/pmus.c | 6 ++++ tools/perf/util/string.c | 48 ++++++++++++++++++++++++++++++++ tools/perf/util/string2.h | 1 + 13 files changed, 128 insertions(+), 44 deletions(-) create mode 100644 tools/perf/tests/util.c -- 2.34.1