From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB9ADCA0FFC for ; Tue, 5 Sep 2023 16:21:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344314AbjIEQVA (ORCPT ); Tue, 5 Sep 2023 12:21:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354036AbjIEJYN (ORCPT ); Tue, 5 Sep 2023 05:24:13 -0400 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E89FEE9 for ; Tue, 5 Sep 2023 02:24:09 -0700 (PDT) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 3856L0e1015029; Tue, 5 Sep 2023 04:23:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=PODMain02222019; bh=vdsUNreevwY+i4D gEt+A9zcUEHYn0SDAckVKt5b8MJM=; b=elWFA3OWgACE2KM9VnrDySKUuwbhgsm XSYyasVImJ2QdnOEVDKYVjevZAle6Jv+MNFsUePph2748SBDxftGGKTKdDCHkQGF QE1nkiwFLCu/ddTc4fSVX4ZbtUnVwVHN6UsDHSmFwUB8DCJvBxs7r3nXNEA3JvBL MK+vhiQ9rPepzpjs0K6ipS5ZQYscx7zUZSCiRHXx7zKVszEFQA8Xds9Nikpe7jez o7SHbSPjnOSnfjQvmfxl6kD5Ia7P7OnDtrhIsGQmOhEiaqCKKByAewLFgpJ/4e+Q bNmZ6GBYetmlC4/r4ps+3ifzpiMFHcYT9MwRvlFLYTk47Y6E4qSfY7g== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3sv2ex3b9n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 05 Sep 2023 04:23:43 -0500 (CDT) Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Tue, 5 Sep 2023 10:23:41 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.2.1118.37 via Frontend Transport; Tue, 5 Sep 2023 10:23:41 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 6810311AA; Tue, 5 Sep 2023 09:23:41 +0000 (UTC) Date: Tue, 5 Sep 2023 09:23:41 +0000 From: Charles Keepax To: Cristian Ciocaltea CC: James Schulman , David Rhodes , Richard Fitzgerald , Jaroslav Kysela , Takashi Iwai , "Liam Girdwood" , Mark Brown , "Stefan Binding" , , , , Subject: Re: [PATCH 3/9] ASoC: cs35l41: Initialize completion object before requesting IRQ Message-ID: <20230905092341.GF103419@ediswmail.ad.cirrus.com> References: <20230902210621.1184693-1-cristian.ciocaltea@collabora.com> <20230902210621.1184693-4-cristian.ciocaltea@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230902210621.1184693-4-cristian.ciocaltea@collabora.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-ORIG-GUID: _NcjRbu42VDmK1efiPjQfRVK7kxcYYxX X-Proofpoint-GUID: _NcjRbu42VDmK1efiPjQfRVK7kxcYYxX X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 03, 2023 at 12:06:15AM +0300, Cristian Ciocaltea wrote: > Technically, an interrupt handler can be called before probe() finishes > its execution, hence ensure the pll_lock completion object is always > initialized before being accessed in cs35l41_irq(). > > Fixes: f5030564938b ("ALSA: cs35l41: Add shared boost feature") > Signed-off-by: Cristian Ciocaltea > --- Acked-by: Charles Keepax Thanks, Charles